-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github workflow #138
Add github workflow #138
Conversation
@@ -11,7 +11,7 @@ import ( | |||
"github.com/segmentio/stats/v4" | |||
) | |||
|
|||
func TestClient(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want to keep this. I don't think the code has been exercised in a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Is it worth adding go vet ./... as well?
I've added golangci to add more tests. Running it against master only for now but once we've fixed most of the failures we can enable it against all PRs. |
No description provided.