exception handling, overloading, global scope #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wenxi-zeng
commented
Apr 24, 2024
•
wenxi-zeng
commented
- better exception handling to capture c++, kotlin and jni exceptions
- add support for overloading methods with the same name but different signature
- add global scope to allow js value persist across multiple scopes
- deadlock prevention for nested scope calls
- more unit tests
- bug fixes
added 7 commits
April 23, 2024 13:02
wenxi-zeng
changed the title
didiergarcia
approved these changes
Apr 26, 2024
wenxi-zeng
added a commit
that referenced
this pull request
Jun 15, 2024
* add try catch to jni * bug fix for exception handler * make get operator return nullable value * add ability to do things in global scope to get away from memory management * bug fix and more unit tests * add comments * add support for overloading methods * optimize thread to avoid deadlock * add global memory table and unit tests for it * handle null property in json object --------- Co-authored-by: Wenxi Zeng <wzeng@twilio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.