Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS does not serialize null values #114

Closed
colinking opened this issue Dec 9, 2019 · 1 comment · Fixed by #129
Closed

iOS does not serialize null values #114

colinking opened this issue Dec 9, 2019 · 1 comment · Fixed by #129
Labels
analytics-ios Issues related to analytics-ios clients bug Something isn't working

Comments

@colinking
Copy link
Contributor

This is due to how analytics-ios doesn't support serializing null values: segmentio/analytics-ios#707

This was recently fixed here: segmentio/analytics-ios#852

But hasn't been released yet. When a new version of analytics-ios is released, we can update the test suite to validate that we start serializing null values:

typewriter/tests/e2e/suite.test.ts

Line 159 in 769e650

// analytics-ios does not serialize nulls, and instead drops those fields.

@colinking colinking added bug Something isn't working analytics-ios Issues related to analytics-ios clients labels Dec 9, 2019
@bsneed
Copy link
Contributor

bsneed commented Jan 30, 2020

This has been released now.

@colinking colinking mentioned this issue Apr 5, 2020
Merged
colinking added a commit that referenced this issue Apr 5, 2020
@colinking
Update iOS E2E Test to reflect null serialization support (#129)
f15d036 
`analytics-ios` recently released support for serializing `null` values in the request sent to the Segment Tracking API: segmentio/analytics-ios#852

This was released as `v3.8.0-beta.1`. For folks using typewriter + `analytics-ios` of at least that version, null values for required fields will now be serialized. Optional fields set to `nil` continue to be removed before serialization.

Fixes #114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analytics-ios Issues related to analytics-ios clients bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update iOS E2E Test to reflect null serialization support segmentio/typewriter
2 participants
@bsneed @colinking