Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json mode in model_dump (default mode is python) #140

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

segments-arnaud
Copy link
Contributor

@segments-arnaud segments-arnaud commented Nov 8, 2023

Use json mode in model dump to make sure only json serializable objects are returned. Also validate the dictionary object and then do model dump to make sure no type coercion happens that causes an error in the frontend.

@segments-arnaud segments-arnaud added the bug Include this pull request in the next patch release (for example, v1.0.0 to v1.0.1) label Nov 8, 2023
segments-arnaud

This comment was marked as duplicate.

@dbbert dbbert merged commit 2cac58e into master Nov 20, 2023
1 check passed
@dbbert dbbert deleted the fix/model-dump-json-mode branch November 20, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Include this pull request in the next patch release (for example, v1.0.0 to v1.0.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants