feature(book detail): reimplement book detail logic #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 1, 2017
| @@ -6,6 +6,7 @@ import { Redirect } from 'react-router-dom'; | |||
|
|
|||
| import Header from '../header/Header'; | |||
| import { borrowBook, deleteBook } from '../../actions/library'; | |||
| import { viewBookDetails } from '../../actions/viewBook'; | |||
There was a problem hiding this comment.
Unable to resolve path to module '../../actions/viewBook' import/no-unresolved
| @@ -11,6 +12,9 @@ import Library from './library/Library'; | |||
| import BookDetail from './library/BookDetail'; | |||
| import Dashboard from './dashboard/Dashboard'; | |||
| import Logout from './auth/Logout'; | |||
| import ForgotPassword from './forgotPassword'; | |||
|
|
|||
| import UpdateProfile from './dashboard/UpdateProfile'; | |||
There was a problem hiding this comment.
Unable to resolve path to module './dashboard/UpdateProfile' import/no-unresolved
| @@ -11,6 +12,9 @@ import Library from './library/Library'; | |||
| import BookDetail from './library/BookDetail'; | |||
| import Dashboard from './dashboard/Dashboard'; | |||
| import Logout from './auth/Logout'; | |||
| import ForgotPassword from './forgotPassword'; | |||
There was a problem hiding this comment.
Unable to resolve path to module './forgotPassword' import/no-unresolved
| @@ -3,6 +3,7 @@ import { BrowserRouter, Route, Switch } from 'react-router-dom'; | |||
|
|
|||
|
|
|||
| import Home from './Home'; | |||
| import History from './history/History'; | |||
There was a problem hiding this comment.
Unable to resolve path to module './history/History' import/no-unresolved
| * @param {Integer} id book Id | ||
| * @return {any} dispatches an action to the redux store | ||
| */ | ||
| export const viewBookDetails = id => dispatch => ( | ||
| axios.get(`${API}/books/${id}`) | ||
| .then((response) => { | ||
| dispatch(getBook(response.data.data)); | ||
| }, (error) => { | ||
| Materialize.toast(error.response.data.message, 2500, 'red darken-4'); |
There was a problem hiding this comment.
'Materialize' is not defined no-undef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
####What does this PR do?
Changes the implementation of login for viewing book details on the client-side
Any background context you want to provide?
The previous implementation relied on setting the book id in the redux store, then reading it that value before sending the required api. The new implementation takes advantage of react-router's match prop and so fetches the book information based on the url parameter, making it more expressive.