#149760707 Users should be able to read books within the app #55

segunolalive · 2017-12-20T11:12:06Z

What does this PR do?

adds the ability to read books within the app

Description of Task to be completed?

Users should be able to read books within the app

How should this be manually tested?

Navigate to the app, click to read a borrowed book from the dashboard

What are the relevant pivotal tracker stories?

#149760707

Screenshots (if appropriate)

- add styles for pdf viewer - adjust notification section height

houndci-bot · 2017-12-20T11:13:09Z

client/components/auth/ResetPasswordForm.jsx

+ * renders reset password form
+ * 
+ * @param {object} props 
+ * 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T11:13:09Z

client/components/auth/ResetPasswordForm.jsx

+/**
+ * renders reset password form
+ * 
+ * @param {object} props 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T11:13:10Z

client/components/auth/ResetPasswordForm.jsx

@@ -6,6 +6,13 @@ import Header from '../Header';
 import Loading from '../common/Loading';


+/**
+ * renders reset password form
+ * 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T11:13:10Z

client/components/common/Categories.jsx

 * @param {object} props
+ * 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T11:13:10Z

client/components/auth/Password.jsx

   * @memberof Password
+   * 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T11:13:11Z

client/components/auth/ForgotPasswordForm.jsx

+/**
+ * renders forgot password form
+ * 
+ * @param {object} props 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T11:13:11Z

client/components/auth/ForgotPasswordForm.jsx

+
+/**
+ * renders forgot password form
+ * 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T11:13:11Z

client/components/Library/BookRow.jsx

-          'templates/images/eloquentjs_cover.png'}
+        src={(props.cover &&
+          requestImageUrl(props.cover, { width: 80 })) ||
+          BOOK_IMAGE_FALLBACK }


'BOOK_IMAGE_FALLBACK' is not defined no-undef

houndci-bot · 2017-12-20T11:13:11Z

client/components/Dashboard/UpdateProfile.jsx

  /**
   * class method that renders a component to the DOM
+   * 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T11:13:11Z

client/components/Dashboard/UpdateProfile.jsx

   * @param {Object} event DOM onSubmit event
-   * @return {Undefined}   sends a network request
+   * 


Trailing spaces not allowed no-trailing-spaces

coveralls · 2017-12-20T11:16:20Z

Coverage increased (+1.5%) to 89.402% when pulling 3b81b8e on feature/read-book into f1104ae on development.

houndci-bot · 2017-12-20T12:34:11Z

server/test/controllers/transactionController.spec.js

+            sandbox = sandbox.restore();
+            done();
+          });
+      });


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T12:34:11Z

server/test/controllers/transactionController.spec.js

+          done();
+        });
+    });
+    it('should send a message if an error occured while getting notifications',


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T12:34:11Z

server/test/controllers/transactionController.spec.js

+          assert.equal(res.body.metadata.total, 3);
+          assert(res.body.notifications.length > 0);
+          assert.equal(res.body.notifications[0].type, 'return');
+          assert.equal(res.body.notifications[0].bookTitle, 'eloquent javascript');


Line 36 exceeds the maximum line length of 80 max-len

houndci-bot · 2017-12-20T12:34:11Z

server/test/controllers/bookController.spec.js

        server.get('/api/v1/books/1')
          .expect(500)
          .end((err, res) => {
            assert.equal(res.status, 500);
-            assert.equal(res.body.message, 'Something went wrong. Internal server error')
+            assert.equal(res.body.message,
+              'Something went wrong. Internal server error');


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T12:34:11Z

server/test/controllers/bookController.spec.js

        server.get('/api/v1/books/1')
          .expect(500)
          .end((err, res) => {
            assert.equal(res.status, 500);
-            assert.equal(res.body.message, 'Something went wrong. Internal server error')
+            assert.equal(res.body.message,


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T12:34:12Z

server/test/controllers/bookController.spec.js

+          .end((err, res) => {
+            assert.equal(res.status, 500);
+            assert.equal(res.body.message,
+              'Something went wrong. Internal server error');


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T12:34:12Z

server/test/controllers/bookController.spec.js

+          .expect(500)
+          .end((err, res) => {
+            assert.equal(res.status, 500);
+            assert.equal(res.body.message,


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T12:34:12Z

server/test/controllers/bookController.spec.js

-        Book.findById = () => Promise.reject(1);
+  });
+  describe('deleteBook', () => {
+    it('should send a message if an error occurs while deleting book',


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T12:34:12Z

server/test/controllers/bookController.spec.js

+          .end((err, res) => {
+            assert.equal(res.status, 500);
+            assert.equal(res.body.message,
+              'Something went wrong. Internal server error');


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T12:34:12Z

server/test/controllers/bookController.spec.js

+          .expect(500)
+          .end((err, res) => {
+            assert.equal(res.status, 500);
+            assert.equal(res.body.message,


Expected a newline after '(' function-paren-newline

…elloBooks into feature/read-book

houndci-bot · 2017-12-20T13:30:36Z

server/test/models/user.spec.js

+          expect(error.errors[0].path).to.equal('email');
+          done();
+        });
+    });


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T13:30:36Z

server/test/models/user.spec.js

+        });
+    });
+
+  it('should raise validation error if email already exists',


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T13:30:37Z

server/test/models/user.spec.js

+          expect(error.errors[0].path).to.equal('email');
+          done();
+        });
+    });


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T13:30:37Z

server/test/models/user.spec.js

+        });
+    });
+
+  it('should raise validation error if email field is missing',


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T13:30:37Z

server/test/models/user.spec.js

+          expect(error.errors[0].type).to.equal('notNull Violation');
+          done();
+        });
+    });


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T13:30:38Z

server/test/models/book.spec.js

+      });
+  });
+
+  it('should raise validation error if title field is missing',


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T13:30:38Z

server/test/controllers/userController.spec.js

+              'Something went wrong. Internal server error');
+            done();
+          });
+      });


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T13:30:38Z

server/test/controllers/userController.spec.js

+          .end((err, res) => {
+            assert.equal(res.status, 500);
+            assert.equal(res.body.message,
+              'Something went wrong. Internal server error');


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T13:30:38Z

server/test/controllers/userController.spec.js

+          .expect(500)
+          .end((err, res) => {
+            assert.equal(res.status, 500);
+            assert.equal(res.body.message,


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T13:30:38Z

server/test/controllers/userController.spec.js

+          });
+      });
+
+    it('should send a message if an error occurs while verifying an account',


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T13:48:13Z

server/app.js

    );
    next();
  });
 }

 app.use('/api-docs', express.static(path.join(__dirname, '/docs')));

-app.use('/', express.static(path.join(__dirname, 'client/static')));
+app.use('/',


Expected a newline after '(' function-paren-newline

houndci-bot · 2017-12-20T13:48:13Z

server/app.js

@@ -27,32 +27,27 @@ if (
    );
    res.header(
      'Access-Control-Allow-Headers',
-      'Authorization, X-PINGOTHER, Origin, X-Requested-With,' +
-      'Content-Type, Accept, x-access-token'
+      'Authorization, X-PINGOTHER, Origin, X-Requested-With, Content-Type, Accept, x-access-token'


Line 30 exceeds the maximum line length of 80 max-len

houndci-bot · 2017-12-20T13:48:13Z

e2e-tests/library.spec.js

      .click('#borrow-book-2-btn')
      .waitForElementVisible('#toast-container')
      .assert.urlEquals('http://localhost:8080/library')
-      .assert.containsText('.toast', 'You currently have this book. Return ' +
-        'it before trying to borrow it again')
+      .assert.containsText('.toast', 'You currently have this book. Return it before trying to borrow it again')


Line 55 exceeds the maximum line length of 80 max-len

houndci-bot · 2017-12-20T13:48:13Z

e2e-tests/library.spec.js

      .click('#borrow-book-2-btn')
      .waitForElementVisible('#toast-container')
      .assert.urlEquals('http://localhost:8080/library')
-      .assert.containsText('.toast', 'You have successfully borrowed ' +
-        'eloquent ruby again. Check your dashboard to read it')
+      .assert.containsText('.toast', 'You have successfully borrowed eloquent ruby again. Check your dashboard to read it')


Line 38 exceeds the maximum line length of 80 max-len

houndci-bot · 2017-12-20T13:48:13Z

e2e-tests/dashboard.spec.js

-      .assert.containsText('.toast', 'You have successfully returned ' +
-        'eloquent javascript')
+      .assert.containsText('.toast',
+        'You have successfully returned eloquent javascript')


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T13:48:14Z

client/sw.js

+  event.waitUntil(self.registration.showNotification(title, options));
+});
+
+self.addEventListener('fetch', (event) => {


Unexpected use of 'self' no-restricted-globals

houndci-bot · 2017-12-20T13:48:14Z

client/sw.js

+  const options = {
+    body: event.data.text()
+  };
+  event.waitUntil(self.registration.showNotification(title, options));


Unexpected use of 'self' no-restricted-globals

houndci-bot · 2017-12-20T13:48:14Z

client/sw.js

+workbox.router.registerRoute('/api-docs/', workbox.strategies.networkFirst());
+
+
+self.addEventListener('push', (event) => {


Unexpected use of 'self' no-restricted-globals

houndci-bot · 2017-12-20T13:48:14Z

client/sw.js

+importScripts('workbox-sw.prod.js');
+
+
+const workbox = new WorkboxSW({


'WorkboxSW' is not defined no-undef

houndci-bot · 2017-12-20T13:48:15Z

client/sw.js

-    });
-  }
-}
+importScripts('workbox-sw.prod.js');


'importScripts' is not defined no-undef

houndci-bot · 2017-12-20T13:56:15Z

server/controllers/UserController.js

-    const email = userData.email;
+    delete req.body.isAdmin;
+    const username = req.body.username;
+    const email = req.body.email;


Use object destructuring prefer-destructuring

houndci-bot · 2017-12-20T13:56:16Z

server/controllers/UserController.js

-    const username = userData.username;
-    const email = userData.email;
+    delete req.body.isAdmin;
+    const username = req.body.username;


Use object destructuring prefer-destructuring

houndci-bot · 2017-12-20T13:56:16Z

server/cronjob.js

-const defaulters = () => (
+/**
+ * function for sending emails to defaulters
+ * 


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2017-12-20T13:56:16Z

server/controllers/BookController.js

          });
        }
        return res.status(403).send({
-          message: 'This book is currently not on your list.' +
-          ' You have either returned it or never borrowed it'
+          message: 'This book is currently not on your list. You have either returned it or never borrowed it'


Line 345 exceeds the maximum line length of 80 max-len

houndci-bot · 2017-12-20T13:56:16Z

server/controllers/BookController.js

@@ -216,8 +255,7 @@ const bookController = {
          .then((borrowed) => {
            if (borrowed && borrowed.returned === false) {
              return res.status(403).send({
-                message: 'You currently have this book.' +
-                ' Return it before trying to borrow it again',
+                message: 'You currently have this book. Return it before trying to borrow it again',


Line 258 exceeds the maximum line length of 80 max-len

houndci-bot · 2017-12-20T13:56:17Z

server/controllers/BookController.js

+            where: { id },
+            returning: true,
+            plain: true,
+          })


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T13:56:17Z

server/controllers/BookController.js

            message:
-              'Successfully added new category, ' +
-              `${category.category}, to Library`,
+              `Successfully added new category, ${category.category}, to Library`,


Line 32 exceeds the maximum line length of 80 max-len

houndci-bot · 2017-12-20T13:56:17Z

client/components/Dashboard/SuggestedBooks.jsx

+        </figure>
+      </div>
+    </Link>
+  ) : <h5 className="center">Nothing here</h5>;


Unexpected newline before ')' function-paren-newline

houndci-bot · 2017-12-20T13:56:17Z

client/components/Dashboard/SuggestedBooks.jsx

+          <figcaption>
+            <h5 className="bold-text">{book.title || ''}</h5 >
+          </figcaption>
+          <img src={book.cover || BOOK_IMAGE_FALLBACK}


'BOOK_IMAGE_FALLBACK' is not defined no-undef

houndci-bot · 2017-12-20T13:56:17Z

client/components/Dashboard/PdfViewer.jsx

+            </div>}
+          <div className="pdf-container">
+            <PDF
+              file={this.props.bookUrl || BOOK_FALLBACK}


'BOOK_FALLBACK' is not defined no-undef

…elloBooks into feature/read-book

houndci-bot · 2017-12-20T14:10:14Z

server/test/controllers/userController.spec.js

+              'Something went wrong. Internal server error');
+            done();
+          });
+      });


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T14:10:14Z

server/test/controllers/userController.spec.js

+          .end((err, res) => {
+            assert.equal(res.status, 500);
+            assert.equal(res.body.message,
+              'Something went wrong. Internal server error');


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T14:10:14Z

server/test/controllers/userController.spec.js

+              'Something went wrong. Internal server error');
+            done();
+          });
+      });


Expected a newline before ')' function-paren-newline

houndci-bot · 2017-12-20T14:10:15Z

server/test/controllers/userController.spec.js

+          .end((err, res) => {
+            assert.equal(res.status, 500);
+            assert.equal(res.body.message,
+              'Something went wrong. Internal server error');


Expected a newline before ')' function-paren-newline

coveralls · 2017-12-20T14:13:33Z

Coverage increased (+1.5%) to 89.402% when pulling 72f8980 on feature/read-book into f1104ae on development.

segunolalive added 15 commits December 11, 2017 12:58

feature(read-book): refactor file upload

83da69c

feature(read-book): add more test cases

8cde2a5

feature(read-book): make newly added category show up in list

7aaeeef

feature(read-book): add book suggestions

7012c3b

feature(read-book): fix navigation links in mobile view

44697d1

feature(read-book): update tests

5923e67

feature(read-book): extract error notification into a module

df0d8a2

feature(read-book): add ability to read book

138db06

feature(read-book): make app offline-first

332d6b8

feature(read-book): format jsDocs

4b76d2d

feature(read-book): compress static files in production

489d7e6

feature(read-book): add more validations

478dc14

feature(read-book): use class properties

12ef31e

feature(read-book): update api documentation

2a5e7df

feature(read-book): update styles

3b81b8e

- add styles for pdf viewer - adjust notification section height

segunolalive temporarily deployed to segunolalive-hellobooks-pr-55 December 20, 2017 11:12 Inactive

houndci-bot reviewed Dec 20, 2017

View reviewed changes

feature(read-book): rename singletons using PascalCase

a2d271e

segunolalive had a problem deploying to segunolalive-hellobooks-pr-55 December 20, 2017 12:33 Failure

houndci-bot reviewed Dec 20, 2017

View reviewed changes

segunolalive added 2 commits December 20, 2017 14:20

feature(read-book): change controller filenames to PascalCase

4294045

Merge branch 'feature/read-book' of https://github.com/segunolalive/h…

550fb38

…elloBooks into feature/read-book

segunolalive had a problem deploying to segunolalive-hellobooks-pr-55 December 20, 2017 13:29 Failure

houndci-bot reviewed Dec 20, 2017

View reviewed changes

feature(read-book): rename bare object export using PascalCase

4a482f1

segunolalive had a problem deploying to segunolalive-hellobooks-pr-55 December 20, 2017 13:47 Failure

houndci-bot reviewed Dec 20, 2017

View reviewed changes

segunolalive force-pushed the feature/read-book branch from 58755e2 to 75b9921 Compare December 20, 2017 13:55

segunolalive temporarily deployed to segunolalive-hellobooks-pr-55 December 20, 2017 13:55 Inactive

houndci-bot reviewed Dec 20, 2017

View reviewed changes

Merge branch 'feature/read-book' of https://github.com/segunolalive/h…

72f8980

…elloBooks into feature/read-book

segunolalive force-pushed the feature/read-book branch from 75b9921 to 72f8980 Compare December 20, 2017 14:08

segunolalive deployed to segunolalive-hellobooks-pr-55 December 20, 2017 14:09 View deployment

houndci-bot reviewed Dec 20, 2017

View reviewed changes

segunolalive merged commit 8bda0cf into development Dec 20, 2017

segunolalive mentioned this pull request Dec 21, 2017

Revert "#149760707 Users should be able to read books within the app" #56

Merged

segunolalive temporarily deployed to segunolalive-hellobooks December 21, 2017 08:21 Inactive

		workbox.router.registerRoute('/api-docs/', workbox.strategies.networkFirst());


		self.addEventListener('push', (event) => {

		importScripts('workbox-sw.prod.js');


		const workbox = new WorkboxSW({

#149760707 Users should be able to read books within the app #55

#149760707 Users should be able to read books within the app #55

Conversation

segunolalive commented Dec 20, 2017

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 20, 2017 • edited

coveralls commented Dec 20, 2017 •

edited