Parallelize begin block for dex module #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
x/dex/module.go
Dismissed
Comment on lines
262
to
266
| go func(contract types.ContractInfoV2) { | ||
| priceKeysToDelete := am.getPriceToDelete(cachedCtx, contract, cutOffTime) | ||
| allPricesToDelete[contract.ContractAddr] = priceKeysToDelete | ||
| wg.Done() | ||
| }(contract) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
There was a problem hiding this comment.
Pretty cool code scanning
BrandonWeng
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
To improve the begin block latency, this PR Parallelize begin block logic for dex module where we delete the historical prices. Removed the gas limit requirement and keep the deletion in order.
Testing performed to validate your change