Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/configure flavors #137

Merged
merged 6 commits into from
Jun 17, 2023
Merged

Feature/configure flavors #137

merged 6 commits into from
Jun 17, 2023

Conversation

shimizu-saffle
Copy link
Collaborator

@shimizu-saffle shimizu-saffle commented Jun 11, 2023

概要

ローカルサーバーと prism のモックサーバーに接続する環境を分けたくなったので、それに伴う変更のPRです!

変更点

  • 各 FLAVOR に応じた起動構成を追加
  • Flavor を表す enum を定義
  • Env が Flavor に応じたフィールドを持つように改修
  • Env インスタンスを提供する Provider を定義

- .dev.env
- .env.local
- .env.prism
- .env.prod
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変なファイル名にしちゃっててごめん😅 変更しといてください🙏

Copy link
Collaborator Author

@shimizu-saffle shimizu-saffle Jun 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#135 で コード再生成してなくて差分でちゃってごめん!🙏

ここから下は流し見で大丈夫です!

@shimizu-saffle shimizu-saffle marked this pull request as ready for review June 11, 2023 13:13
@shimizu-saffle
Copy link
Collaborator Author

@seigi0714 時間ある時確認よろしく〜!🙏

Copy link
Contributor

@seiginakamura0714 seiginakamura0714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうLGTM!

@shimizu-saffle shimizu-saffle merged commit 83ce2f3 into main Jun 17, 2023
3 checks passed
@shimizu-saffle shimizu-saffle deleted the feature/configure-flavors branch June 17, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants