Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

旅詳細ページのUI実装 #89

Merged
merged 11 commits into from
Apr 29, 2023
Merged

旅詳細ページのUI実装 #89

merged 11 commits into from
Apr 29, 2023

Conversation

seigi0714
Copy link
Owner

概要

  • 旅詳細ページのUI実装

改修内容

  • 画面遷移
  • 旅詳細画面UI実装
  • タブ切り替え実装

実装後
https://user-images.githubusercontent.com/61484852/233990273-eafb6e5e-d7cf-41f3-ba3e-2025a42997c8.mov

Copy link
Owner Author

@seigi0714 seigi0714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimizu-saffle
旅詳細画面の外枠だけ実装した!時間あるとき見てくれたら嬉しい!
UIのアイデアとかイケてないとこあったらどんどん言ってほしい!

decoration: const BoxDecoration(
image: DecorationImage(
image: NetworkImage(
'https://tsunagutabi.com/wp-content/uploads/2020/04/%E6%97%85%E8%A1%8C%E3%83%96%E3%83%AD%E3%82%B0%E3%81%AB%E3%81%8A%E3%81%99%E3%81%99%E3%82%81%E3%81%AE%E3%83%95%E3%83%AA%E3%83%BC%E7%94%BB%E5%83%8F%EF%BC%86%E7%B4%A0%E6%9D%90%E3%82%B5%E3%82%A4%E3%83%88%E3%81%BE%E3%81%A8%E3%82%81.jpg',
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[memo]
一旦仮の画像入れてる!
その旅ごとのホーム画像みたいなのを入れれる用にする!

title: Text(
trip.title.value,
style: context.textTheme.titleLarge,
),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[memo]
ここtitleで取るのちょっとイケてないから消したいけど,ちょいめんどくさそうやから一旦おいてる!
スクリーンショット 2023-04-24 21 37 06

@shimizu-saffle
Copy link
Collaborator

CI 失敗してるのだけ直しといた!

Copy link
Collaborator

@shimizu-saffle shimizu-saffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seigi0714
この PR に PR 出してみたから、そっちにコメントもらえると嬉しい!
#98

const TripDetailPage(this.id, {super.key});

static const path = ':id';
static const scheduleTabIndex = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こうするのいいね!👍


@override
Widget build(BuildContext context, WidgetRef ref) {
final tabIndex = useState(scheduleTabIndex);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こうしたことなかった!ためになる!

import 'package:trip_app_nativeapp/view/widgets/trips/trip_overview_card.dart';
import 'package:trip_app_nativeapp/view/widgets/trips/trip_schedule.dart';

class TripDetailPage extends HookConsumerWidget {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デザインめっちゃ良い感じだと思う!🧑‍🎨

TripDetailPage のルート指定と遷移方法の変更案
@seigi0714
Copy link
Owner Author

この PR に PR 出してみたから、そっちにコメントもらえると嬉しい!

ありがとう!マージしちゃった!

Copy link
Collaborator

@shimizu-saffle shimizu-saffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@seigi0714 seigi0714 merged commit 0a11746 into main Apr 29, 2023
3 checks passed
@seigi0714 seigi0714 deleted the feature/trip_detail_page branch April 29, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants