-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
旅詳細ページのUI実装 #89
旅詳細ページのUI実装 #89
Conversation
07d79b9
to
6075682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shimizu-saffle
旅詳細画面の外枠だけ実装した!時間あるとき見てくれたら嬉しい!
UIのアイデアとかイケてないとこあったらどんどん言ってほしい!
decoration: const BoxDecoration( | ||
image: DecorationImage( | ||
image: NetworkImage( | ||
'https://tsunagutabi.com/wp-content/uploads/2020/04/%E6%97%85%E8%A1%8C%E3%83%96%E3%83%AD%E3%82%B0%E3%81%AB%E3%81%8A%E3%81%99%E3%81%99%E3%82%81%E3%81%AE%E3%83%95%E3%83%AA%E3%83%BC%E7%94%BB%E5%83%8F%EF%BC%86%E7%B4%A0%E6%9D%90%E3%82%B5%E3%82%A4%E3%83%88%E3%81%BE%E3%81%A8%E3%82%81.jpg', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[memo]
一旦仮の画像入れてる!
その旅ごとのホーム画像みたいなのを入れれる用にする!
title: Text( | ||
trip.title.value, | ||
style: context.textTheme.titleLarge, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4b73cff
to
640f977
Compare
CI 失敗してるのだけ直しといた! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seigi0714
この PR に PR 出してみたから、そっちにコメントもらえると嬉しい!
#98
const TripDetailPage(this.id, {super.key}); | ||
|
||
static const path = ':id'; | ||
static const scheduleTabIndex = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こうするのいいね!👍
|
||
@override | ||
Widget build(BuildContext context, WidgetRef ref) { | ||
final tabIndex = useState(scheduleTabIndex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こうしたことなかった!ためになる!
import 'package:trip_app_nativeapp/view/widgets/trips/trip_overview_card.dart'; | ||
import 'package:trip_app_nativeapp/view/widgets/trips/trip_schedule.dart'; | ||
|
||
class TripDetailPage extends HookConsumerWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
デザインめっちゃ良い感じだと思う!🧑🎨
TripDetailPage のルート指定と遷移方法の変更案
ありがとう!マージしちゃった! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
概要
改修内容
実装後
https://user-images.githubusercontent.com/61484852/233990273-eafb6e5e-d7cf-41f3-ba3e-2025a42997c8.mov