Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export feature is broken #16

Closed
OlliV opened this issue Mar 17, 2017 · 9 comments
Closed

Export feature is broken #16

OlliV opened this issue Mar 17, 2017 · 9 comments
Labels

Comments

@OlliV
Copy link

OlliV commented Mar 17, 2017

It seems that I can't export anymore. I can decrypt my old backups just fine but since I don't know when the new backups can't be decrypted anymore. This is the error I'm getting with openssl enc -d -a -aes-256-cbc -in <file>:

bad decrypt
88625:error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt:/BuildRoot/Library/Caches/com.apple.xbs/Sources/OpenSSL098/OpenSSL098-64.30.2/src/crypto/evp/evp_enc.c:330:

Maybe something is appended to the key?

I'm using Sailfish OS 2.1 and SailOTP 1.5

@OlliV
Copy link
Author

OlliV commented Mar 17, 2017

Probably the same issues as #14

@seiichiro0185
Copy link
Owner

Seems like there is some kind of problem with the encryption, I agree that this and #14 probably have a common cause. Strange thing is that I didn't change anything in the encryption code since a long time.. maybe some kind of incompatibility with new QT-Version in SFOS 2.1. I'll investigate this further as soon as I get some free time an my hands..

Just out of interest, are you seeing this on a Phone or a Tablet, or both, since #14 was specifically only happening on a Jolla Tablet?

@OlliV
Copy link
Author

OlliV commented Mar 18, 2017

I'm using Jolla C.

@seiichiro0185
Copy link
Owner

I created a test build with a changed AES-Engine, which seems to be more stable after my limited Tests. You can get it here: https://mail.seiichiro0185.org/index.php/s/GJQoXPM5BNR2r6o

Decrypting the created files using the Terminal should work with:
base64 -d sailotp_20170319.aes | openssl enc -d -aes-256-cbc

Let me know If you see any improvements with the new build

@m01
Copy link

m01 commented May 10, 2017

I hit the same issue with the SailOTP app from the Jolla store; your temporary build gives legible JSON after decryption 👍

@physkets
Copy link

I see the same issue; tried to decrypt an exported tokens file, unsuccessfully.

seiichiro0185 added a commit that referenced this issue Oct 30, 2017
- Bugfix for Github Issues #14 / #16
@seiichiro0185
Copy link
Owner

Should be fixed (according to my tests) with Version 1.6. Also on some versions of openssl you may need an adapted command to decrypt the export file due to some changed defaults:

openssl enc -d -a -A -md md5 -aes-256-cbc -in sailotp_20160723.aes

I'm closing this issue, should it still be there feel free to reopen.

@physkets
Copy link

physkets commented Nov 7, 2017

Can you make it so that the app displays instructions to decrypt when one exports? That will make it convenient for people unfamiliar with openssl.

@seiichiro0185
Copy link
Owner

I'll add the openssl commandline to the export screen in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants