Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.2: UI: real-time filter search box up top #38

Closed
lkraav opened this issue Nov 2, 2019 · 6 comments · Fixed by #41
Closed

1.8.2: UI: real-time filter search box up top #38

lkraav opened this issue Nov 2, 2019 · 6 comments · Fixed by #41

Comments

@lkraav
Copy link

lkraav commented Nov 2, 2019

With large amounts of keys saved, finding the correct entry to use becomes increasingly cumbersome.

What if we put a search box on top, that would real-time filter entries list with each new letter entered? In most cases with such filtering interface, you can narrow down your search by entering on average only 2 letters.

Feels like a significant UX win. Your thoughts?

@seiichiro0185
Copy link
Owner

seiichiro0185 commented Nov 3, 2019

Sounds like a good solution to the "to much tokens" problem. At the moment I don't have much free time to work on SailOTP, but I'm always open for Pull Requests :)
I would probably make it configurable (for Cases where all Tokens fit on one Page without scrolling)

ZeiP added a commit to ZeiP/sailotp that referenced this issue Jan 3, 2021
seiichiro0185 added a commit that referenced this issue Jan 4, 2021
#38: Add a search box to the main view.
@lkraav
Copy link
Author

lkraav commented Jan 4, 2021

Wow, what a gift for 2021 🚀 Tyvm all.

@seiichiro0185
Copy link
Owner

I've put Version 1.9.0 with Search support on OpenRepos. Harbour will follow if no Problems are reported and maybe some more Translations are done. Thanks @ZeiP for implementing it :)

@lkraav
Copy link
Author

lkraav commented Jan 4, 2021

Thanks. I installed it and wondering if y'all agree - progress bar is looking a bit glitchy up there.

Maybe progress bar could be moved below search box to get its full screen width space back?

@ZeiP
Copy link
Contributor

ZeiP commented Jan 4, 2021

Do you mean that the progress bar was previously full-width? I didn't change it at all, ie. it used to be the same way only half-width beside the application name. So that hasn't changed, but it's of course something that could be changed. IMO it's better this way, as the progress bar doesn't need more width but the search box benefits from being full-width. Of course one can ask if the application name needs to be in the main view at all?

@seiichiro0185
Copy link
Owner

seiichiro0185 commented Jan 4, 2021

Since some version it is like in 1.9 (half width beside the Name). It was full width in earlier versions, which got bugged as SFOS introduced light ambiances IIRC (somehow the positions was different between light and dark, which led to the bar beeing over the first entry on light ambiances). The current layout was a compromise which worked okish with both light and dark ambiances.

I'm by no means an UI-Designer (my "natural environment" is a Terminal ;) ), so if someone has a better way to do it (that also does not break with different ambiance types) im Open for Ideas / Pull Requests as always

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants