Homogenized annotate arguments #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make `strict` and `flexible_horizontal_components` annotate arguments instead of listing them separately in the function head. - Remove default_args set in the constructor by overwrites to _annotate_args. This ensures that the documentation lists the correct default values. - Factor out function to query arguments with defaults from the annotate_args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strictandflexible_horizontal_componentsannotate arguments instead of listing them separately in the function head.default_argsset in the constructor by overwrites to_annotate_args. This ensures that the documentation lists the correct default values._annotate_args.