Add an option for AddGap and ChannelDropout to modify label directly #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option for AddGap and ChannelDropout to modify labels directly. For AddGap, the gap can be added to both the waveform and the labels. For ChannelDropout, if all channels are zeros, labels will also be zeroed out. If there is a noise label, the noise label within the gap is 1.
Add two tests 'test_channel_dropout_modify_labels_directly' and 'test_add_gap_to_waveform_and_labels' to test the option of modifying labels directly for AddGap and ChannelDropout
|
Thanks for the contribution. I'll have a look at it but may not be able to do so before next week. |
|
Thanks for the contribution! That was a very pleasant PR to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull request #222, only the metadata is changed if there is any pick in a gap.
It may be helpful to add an option to change labels directly. For example. when one waveform is staked on another (e.g. benchmark/augmentations.py) to generate a new trace, the metadata is kept unchanged and only the label is changed. In this case, adding the gap to the labels directly is a better choice.
label_keysandnoise_idtoAddGapandChannelDropouttest_channel_dropout_with_picks_in_gapandtest_add_gap_to_waveform_and_labelsI forgot to pull your commit at the beginning, so I manually resolved the conflicts. I hope it didn't break the commits b253784 and 319d944