Cornerflow test #50
Merged
Cornerflow test #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Patol75
requested changes
Sep 9, 2022
|
I'll need to revisit this later to fully understand what is going on, but for now I think it's worth having these even just to check that the pathline routines run properly. This PR also got a bit out of hand so it includes a bunch of infrastructure that will be useful later (logging, visualisation, etc.) |
The deformation gradient tensor is what we actually manipulate in the code. DF_ij/Dt = L_ik F_kj
Still need to track down why the misalignment angle sometimes blows up near the end.
Still need to change the debug statements to not print so much data.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This seems to be the strongly recommended method
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Patol75
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cornerflow test, integration fixes and logging.
Draft because I still need to:
Optimise time to createNope, it's the diagnostics and output happening after one Mineral finishes and before the next one is created, not optimising this hereMinerals, which seems a bit slow compared to the solver timeDebug why my CPO is not aligning to the extent shown in Kaminski 2002 fig. 5Postponed until further analysis, could be differences in the spherical averaging.Set up a test ordering so more complex tests are run later, and quick tests can fail early and give a big red XNope, there's not an easy way to do it in pytest and I don't want too many hacks in my testing code--log-cli-levelin CI -- various reasons, including buggy interaction of pytest CLI args and other loggers (logging level and output capture sensitive to environment and confusing pytest-dev/pytest#10283)