Skip to content
This repository has been archived by the owner on Oct 5, 2019. It is now read-only.

Slider events not being called #61

Merged
merged 1 commit into from May 22, 2015
Merged

Slider events not being called #61

merged 1 commit into from May 22, 2015

Conversation

david-hollifield
Copy link
Contributor

Slider events defined as attributes were not being called. Updated
invoker function with proper signature.

Slider events defined as attributes were not being called. Updated
invoker function with proper signature.
@seiyria
Copy link
Owner

seiyria commented May 22, 2015

Thanks!

seiyria added a commit that referenced this pull request May 22, 2015
Slider events not being called
@seiyria seiyria merged commit dbb10c6 into seiyria:master May 22, 2015
@hmillet
Copy link
Contributor

hmillet commented Jun 11, 2015

@david-hollifield @seiyria
Hi ! I've got a problem with this commit.

The fact that event name are in full lowercase (onstartslide instead of onStartSlide) make events no more working

Why did you do this ? Can we revert ?

@hmillet
Copy link
Contributor

hmillet commented Jun 11, 2015

In fact, we must aggree and write a small documentation for the usage of events.

In test.html, we can find :

          on-slide="slideDelegate(value, $event)"

on-slide or onslide ?
slideDelegate(value, $event) or slideDelegate($event, value) or slideDelegate ?

@seiyria
Copy link
Owner

seiyria commented Jun 11, 2015

I'm fine with some better documentation. Really, this was a quick job to get something working, but then people started using it, haha.

@hmillet
Copy link
Contributor

hmillet commented Jun 11, 2015

I understand ;-)

It was a good and useful work for people....

Just choose the syntax, I'll write the doc (and upgrade code if necessary)

@seiyria
Copy link
Owner

seiyria commented Jun 11, 2015

If you could follow the style of bootstrap-slider, that would be for the best. People will be familiar enough with that, I think. Thanks a ton!

@david-hollifield
Copy link
Contributor Author

Fixed in pull request #70

@hmillet
Copy link
Contributor

hmillet commented Jun 11, 2015

thanks for the fix

So we are agree we will use on-slide, on-start-slide, on-stop-slide attributes

@david-hollifield
Copy link
Contributor Author

No problem. Using the non dashed versions was just a brain fart.

@seiyria
Copy link
Owner

seiyria commented Jun 11, 2015

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants