Properly check if the slider values have changed #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! |
rovolution
requested changes
Dec 6, 2018
test/specs/KeyboardSupportSpec.js
Outdated
| // FIXME: Setup async event dispatch | ||
| // $handle1[0].dispatchEvent(keyboardEvent); | ||
| mySlider.handle1Keydown(keyboardEvent); | ||
| expect(hasSlideStarted).toBe(true); |
There was a problem hiding this comment.
so this may not work the way you expect it to since the callbacks within the event listeners may not be invoked until the next tick of the event loop.
I would write this test in an async manner using the done callback and just do the assertions within the slideStop event listener and invoke done() on completion
test/specs/KeyboardSupportSpec.js
Outdated
| var hasSlideStopped = false; | ||
| options.value = [-100, 0]; | ||
| mySlider = new Slider($('#testSlider1')[0], options); | ||
| // $handle1 = $('#mySlider').find('.slider-handle:first'); |
test/specs/KeyboardSupportSpec.js
Outdated
| var mySlider; | ||
| var keyboardEvent; | ||
| var options; | ||
| // var $handle1; |
jespirit
force-pushed
the
issue-878
branch
2 times, most recently
from
7a9ba10
to
97fbd5f
Compare
rovolution
approved these changes
Dec 7, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #878
I'll add unit tests later.
You can check the JSFiddle in the issue.
Pull Requests
Please accompany all pull requests with the following (where appropriate):
grunt testin your Terminal within the bootstrap-slider repository directory