refactor

sekiguchi-nagisa · Apr 19, 2024 · d1b8a17 · d1b8a17
1 parent 8e617d9
commit d1b8a17
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/redir.cpp b/src/redir.cpp
@@ -72,14 +72,10 @@ static int doIOHere(const StringRef &value, int newFd, bool insertNewline) {
 
   if (value.size() + (insertNewline ? 1 : 0) <= PIPE_BUF) {
     int errnum = 0;
-    if (write(pipe[WRITE_PIPE], value.data(), sizeof(char) * value.size()) < 0) {
+    if (write(pipe[WRITE_PIPE], value.data(), value.size()) < 0 ||
+        write(pipe[WRITE_PIPE], "\n", insertNewline ? 1 : 0) < 0) {
       errnum = errno;
     }
-    if (insertNewline) { // for here str (insert newline)
-      if (errnum == 0 && write(pipe[WRITE_PIPE], "\n", 1) < 0) {
-        errnum = errno;
-      }
-    }
     pipe.close();
     return errnum;
   } else {