Add WorldEdit integration to AdvancedPortals #307
Conversation
* New config option to enable WorldEdit integration * New command "/portal we-selection <name>" to select the Portal as WorldEdit selection * When enabled: Create portals with WorldEdit selections, disable AdvancedPortal's Wand
Joo200
force-pushed
the
feature/worldedit
branch
from
9b9ba12
to
e04181e
Compare
|
I need to do some manual checks as some large chunks of code have been altered as well as the velocity library build version had been also modified as part of the same pr. I've added it to my calendar for tomorrow afternoon so I should be able to review this after work. Also big thanks for following the correct commit standards 🥰 |
|
Yes, I had to update the Velocity version. I was unable to compile AdvancedPortals without that. You can remove this version update but I didn't need any code changes for that. |
src/main/java/com/sekwah/advancedportals/bukkit/listeners/Listeners.java
Outdated
Show resolved
Hide resolved
| @@ -88,12 +89,13 @@ dependencies { | |||
| implementation "org.spigotmc:spigot-api:1.16.1-R0.1-SNAPSHOT" | |||
| implementation "net.md-5:bungeecord-api:1.16-R0.4" | |||
|
|
|||
| implementation "com.velocitypowered:velocity-api:1.1.9" | |||
| annotationProcessor "com.velocitypowered:velocity-api:1.1.9" | |||
| implementation "com.velocitypowered:velocity-api:3.1.0" | |||
There was a problem hiding this comment.
Compiles just fine so seems to be good.
I believe they may have removed some old versions because they wanted to force people over, it may also be because the old ones were vulnerable to log4shell attacks. Good job generally on the PR :) Other than the broken logic on the if statement I believe everything else is good to go. Though once that's fixed ill do a quick basic check with and without to make sure the main logic is all working fine. You may also want to check the Or you can explain the general stuff and I'll try to update the documentation on the weekend. |
|
🚀 PR was released in |
As mentioned here, you're fine with a WorldEdit integration.
#44
And I want to add it in this PR.
I really like AdvancedPortals but too many wands are terrible. I added a config option to enable WorldEdit integration.
With that option:
When WorldEdit is installed:
WorldEdit is marked as soft-depend, you don't need to install worldedit for AdvancedPortals.