Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElfLoader should use monitor.S only if CONFIG_ARM_MONITOR_HOOK is set #47

Closed
axel-h opened this issue Oct 27, 2020 · 2 comments
Closed

ElfLoader should use monitor.S only if CONFIG_ARM_MONITOR_HOOK is set #47

axel-h opened this issue Oct 27, 2020 · 2 comments

Comments

@axel-h
Copy link
Member

axel-h commented Oct 27, 2020

The file monitor.S should only be compiled in (or it's content take into account), when CONFIG_ARM_MONITOR_HOOK is set. Otherwise the content should be ignored, so any accidental referenced make the build fail.

We ran into this issue when adding a new imx6 board platform, where we had to define something there to VECTOR_BASE even if this is not used anywhere because CONFIG_ARM_MONITOR_HOOK is not supported there.
@axel-h
Copy link
Member Author

axel-h commented Mar 8, 2021

See also #53

@axel-h axel-h mentioned this issue Mar 8, 2021
Merged
@kent-mcleod
Copy link
Member

Resolved by #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kent-mcleod @axel-h