HTTP packet fragmentation support #1212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcofr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1212 +/- ##
=======================================
Coverage 82.40% 82.40%
=======================================
Files 163 163
Lines 20938 20938
Branches 7906 7906
=======================================
+ Hits 17254 17255 +1
+ Misses 3013 3012 -1
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jpcofr
force-pushed
the
dev_HTTP_packet_fragmentation_support
branch
from
8b150b5
to
22a85a0
Compare
jpcofr
force-pushed
the
dev_HTTP_packet_fragmentation_support
branch
2 times, most recently
from
124cba5
to
a1cbffe
Compare
reassembly implementation
jpcofr
force-pushed
the
dev_HTTP_packet_fragmentation_support
branch
from
a1cbffe
to
005f159
Compare
jpcofr
force-pushed
the
dev_HTTP_packet_fragmentation_support
branch
from
005f159
to
1b0669b
Compare
jpcofr
commented
Oct 9, 2023
The payload is a JSON object. HTTP1_chunk_1 holds the HTTP 200 message. HTTP1_chunk_2 holds the first part of the packet. HTTP1_chunk_3 holds the last part of the packet.
jpcofr
force-pushed
the
dev_HTTP_packet_fragmentation_support
branch
from
bb55a98
to
2f7dcb1
Compare
Test is failing as, among other issues, the format may not work correctly.
Apparently the packet types are unable to detect chunk continuations. The sample capture is https://wiki.wireshark.org/uploads/__moin_import__/attachments/SampleCaptures/http-chunked-gzip.pcap
|
@jpcofr are you still working on this PR? |
|
@seladb Currently, no. I am planning to continue working on it soon. |
|
@jpcofr this PR has been open for a very long time. Maybe we can close it and you can work on it on a separate branch and open another PR once ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.