Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General icons in taskbar #4

Open
stefonarch opened this issue Sep 1, 2022 · 19 comments
Open

General icons in taskbar #4

stefonarch opened this issue Sep 1, 2022 · 19 comments

Comments

@stefonarch
Copy link
Contributor

screen_gio_17:05:14_

As for telegram and keepassXC , maybe there are others. LXimage-qt is hardly visible, 3rd from the right.

@selairi
Copy link
Owner

selairi commented Sep 1, 2022

There is a issue with icons and panel size. Which is your panel size?

@stefonarch
Copy link
Contributor Author

Which is your panel size?

40, with default size 49 no change here.

@selairi
Copy link
Owner

selairi commented Sep 2, 2022

Can you send me your "yatbw.json" file, please?

Thanks

@stefonarch
Copy link
Contributor Author

yatbfw.json.tar.gz

I saw now that kcolorchooser has the same issue.

@selairi
Copy link
Owner

selairi commented Sep 3, 2022

I have checked your "yatbfw.json" file in my desktop`and works properly.
You have selected "Papirus-Dark" icon theme. I have checked "Papirus-Dark" folder and there is no "lximage-qt" icon.
Yatbfw looks up icons in "Papirus-Dark" theme, but if it is not found, it will try other theme.
My system is taking "lximage-qt" icon from "ePapirus" icon theme. Can you check if it is installed in your system, please?

I have done some changes in your settings.

yatbfw.tar.gz

You can run:

yatbfw --debug

to get debug output.

Thanks!

@stefonarch
Copy link
Contributor Author

stefonarch commented Sep 3, 2022

Ok, thanks for the screenshot! I figured out a similar tool triggered with Print key.
With -- debug I noticed that it's non finding the appimage icon and I installed telegram normally and it works.

For lximage and kcolorchooser nothing to do - it's not finding it neither with plataro nor with papirus or breeze.
epapirus is not installable easy on Arch it's not even in AUR. EDIT: I've it installed I see, but no change also with that.

It looks thatlxqt-appearanceoverwrites any setting in yatbfw.json, it never changing icons if not changing them in the system.


locate lximage-qt | grep icons

/usr/share/icons/Papirus/16x16/apps/lximage-qt.svg
/usr/share/icons/Papirus/22x22/apps/lximage-qt.svg
/usr/share/icons/Papirus/24x24/apps/lximage-qt.svg
/usr/share/icons/Papirus/32x32/apps/lximage-qt.svg
/usr/share/icons/Papirus/48x48/apps/lximage-qt.svg
/usr/share/icons/Papirus/64x64/apps/lximage-qt.svg
/usr/share/icons/Plataro/apps/scalable/lximage-qt.svg
/usr/share/icons/hicolor/48x48/apps/lximage-qt.png

/usr/share/icons/Papirus/16x16/apps/kcolorchooser.svg                                                                                                            
/usr/share/icons/Papirus/22x22/apps/kcolorchooser.svg
/usr/share/icons/Papirus/24x24/apps/kcolorchooser.svg
/usr/share/icons/Papirus/32x32/apps/kcolorchooser.svg
/usr/share/icons/Papirus/48x48/apps/kcolorchooser.svg
/usr/share/icons/Papirus/64x64/apps/kcolorchooser.svg
/usr/share/icons/Plataro/apps/scalable/kcolorchooser.svg
/usr/share/icons/breeze/apps/48/kcolorchooser.svg
/usr/share/icons/breeze-dark/apps/48/kcolorchooser.svg
/usr/share/icons/hicolor/16x16/apps/kcolorchooser.png
/usr/share/icons/hicolor/22x22/apps/kcolorchooser.png
 Start painting Icon lximage-qt
[void Icon::paint(cairo_t*, uint32_t, uint32_t, uint32_t, uint32_t)] Line:297    End painting Icon lximage-qt
[void Icon::paint(cairo_t*, uint32_t, uint32_t, uint32_t, uint32_t)] Line:271    Start painting Icon lximage-qt
[void Icon::paint(cairo_t*, uint32_t, uint32_t, uint32_t, uint32_t)] Line:297    End painting Icon lximage-qt

@selairi
Copy link
Owner

selairi commented Sep 4, 2022

@stefonarch I am working on this issue. Please be patient. I have not been able to reproduce the error and I am checking the code.
It would help if you could send me the full output of the command:

yatbfw --debug 2> output.txt

Thanks

@stefonarch
Copy link
Contributor Author

Please be patient

O I am, thanks for this panel!

Here with 2 general icons (font manager and kcolorchooser)
output.txt

@selairi
Copy link
Owner

selairi commented Sep 6, 2022

I have done some changes. Could you be so kind to check it?

If it doesn't work properly, then send me the "yatbfw --debug 2> output.txt" output, please.

Thanks

@stefonarch
Copy link
Contributor Author

stefonarch commented Sep 7, 2022

For kcolorchooser it looks fixed now, font-manager no.
out2.txt

There were some other ones, I don't remember which though atm

@selairi
Copy link
Owner

selairi commented Sep 7, 2022

Thanks for your answer. The file "out2.txt" is empty. Maybe you have forgotten the "2":

yatbfw --debug 2> output.txt

@stefonarch
Copy link
Contributor Author

Was in hurry, sorry.
output2.txt

@stefonarch
Copy link
Contributor Author

Last ones in the club:

  • all virtualbox windows
  • element-desktop

@selairi
Copy link
Owner

selairi commented Sep 10, 2022

I have just uploaded an update. I cannot reproduce this bug and I have problems to fix it.

@selairi
Copy link
Owner

selairi commented Sep 17, 2022

I have uploaded a new version. Is it fixed now?

@stefonarch
Copy link
Contributor Author

For font-manager it's fixed!
For virtualbox I see that the correct icon is displayed for a fraction of seconds and then switches to general icon, backintime is still generic. lxqt-panel is also generic but I think that cannot be different ;)

@selairi
Copy link
Owner

selairi commented Sep 18, 2022

I have just uploaded a new push. VirtualBox icon is properly shown.

lxqt-panel needs a desktop file to show its icon on Wayland.

The origin of the problem is Wayland protocol. There is no way of set icons for applications. toplevel protocol lets get the applications id. The id can be used to read the desktop file and get the application icon.
Each application send the id in different way, the D-Bus name, the application name, the window tittle,...

If you find more wrong icons, please, send me.

Thanks

@stefonarch
Copy link
Contributor Author

stefonarch commented Sep 18, 2022

Yep, Virtualbox is fixed too now, thanks! Found another one, gimp...
I know that lxqt-panel and lxqt-runner have no icons, they should be excluded, but this would need a setting I think, no idea how lxqt-panel exclude runner.

@stefonarch
Copy link
Contributor Author

I see also gimp fixed now, IMO this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants