Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage TF sessions internally #109

Closed
jklaise opened this issue Jul 3, 2019 · 1 comment
Closed

Manage TF sessions internally #109

jklaise opened this issue Jul 3, 2019 · 1 comment
Labels
Type: Enhancement A better way of doing things

Comments

@jklaise
Copy link
Member

jklaise commented Jul 3, 2019

We don't want the user to have to manage TF sessions externally from the library, so the logic should be internal to the algorithms (currently counterfactuals, cfproto and cem). However, this is not straightforward due to the way sessions are kept alive. On first investigation there seem to be two choices:

  1. Use custom decorators (e.g. autoflow in GPFlow)
  2. Rewrite everything using eager mode (could align with Unify counterfactual and cfproto methods #108)
@jklaise jklaise added the Type: Enhancement A better way of doing things label Jul 3, 2019
@jklaise
Copy link
Member Author

jklaise commented Sep 16, 2019

Closed by #120

@jklaise jklaise closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement A better way of doing things
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jklaise