Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when no anchor is found #30

Closed
jklaise opened this issue Mar 28, 2019 · 1 comment
Closed

Add warning when no anchor is found #30

jklaise opened this issue Mar 28, 2019 · 1 comment
Assignees
@arnaudvl
Labels
Type: Enhancement A better way of doing things
Projects
0.1.0

Comments

@jklaise
Copy link
Member

jklaise commented Mar 28, 2019

Currently the Anchor explainer returns an anchor of maximum precision when the maximum number of elements in the anchor is reached. We should warn the user that the desired threshold has not been reached via e.g. a logger.warn message as well as a metadata flag in the return.
@jklaise jklaise added the Type: Enhancement A better way of doing things label Apr 24, 2019
@arnaudvl arnaudvl mentioned this issue May 7, 2019
Merged
@jklaise
Copy link
Member Author

jklaise commented May 7, 2019

Closed by #74

@jklaise jklaise closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnaudvl arnaudvl

Labels
Type: Enhancement A better way of doing things
Projects
No open projects
0.1.0
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jklaise @arnaudvl