Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize AchorText tests #75

Closed
jklaise opened this issue May 7, 2019 · 3 comments
Closed

Optimize AchorText tests #75

jklaise opened this issue May 7, 2019 · 3 comments
Assignees
@jklaise

Comments

@jklaise
Copy link
Member

jklaise commented May 7, 2019

The current tests take too long, sometimes making the builds timeout (e.g. #73 )
@jklaise jklaise added the CI label May 7, 2019
@jklaise jklaise self-assigned this May 7, 2019
@jklaise
Copy link
Member Author

jklaise commented Jul 1, 2019

Some ideas for mocking Spacy models: https://stackoverflow.com/questions/56728218/how-to-mock-spacy-models-doc-objects-for-unit-tests

@jklaise
Copy link
Member Author

jklaise commented Jul 3, 2019

#110 has decreased the typical test suite time from ~17 minutes to ~7 minutes, so once it's merged we can probably close this as well.

@jklaise
Copy link
Member Author

jklaise commented Jul 5, 2019

Closing as resolved by #110

@jklaise jklaise closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jklaise jklaise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jklaise