-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support react / JSXText selector? #5
Comments
added support for this in v1.2.0; thanks for the feedback! |
seleb
pushed a commit
that referenced
this issue
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As far as I can tell the rule fails to find smart quotes that are embedded in JSX expressions.
From poking around at the code it seems like it would have to also match
JSXText
in addition toLiteral
here: https://github.com/seleb/eslint-plugin-no-smart-quotes/blob/master/lib/rules/no-smart-quotes.js#L47Additionally I think it would need to handle auto-fixing differently (the detection part appeared to work fine)
Example component:
The text was updated successfully, but these errors were encountered: