Skip to content

Commit

Permalink
During selection and unselection events, retrieve cached item data us…
Browse files Browse the repository at this point in the history
…ing the original 'option' element as the cache lookup key instead of the event target
  • Loading branch information
jayaddison committed Jul 13, 2022
1 parent 9ce61fd commit 8258567
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 6 deletions.
8 changes: 6 additions & 2 deletions dist/js/select2.full.js
Expand Up @@ -3403,11 +3403,15 @@ S2.define('select2/data/select',[
this.container = container;

container.on('select', function (params) {
self.select(params.data);
var option = container.$element.find('option')[0];
var data = Utils.GetData(option, 'data');
self.select(data);
});

container.on('unselect', function (params) {
self.unselect(params.data);
var option = container.$element.find('option')[0];
var data = Utils.GetData(option, 'data');
self.unselect(data);
});
};

Expand Down
8 changes: 6 additions & 2 deletions dist/js/select2.js
Expand Up @@ -3403,11 +3403,15 @@ S2.define('select2/data/select',[
this.container = container;

container.on('select', function (params) {
self.select(params.data);
var option = container.$element.find('option')[0];
var data = Utils.GetData(option, 'data');
self.select(data);
});

container.on('unselect', function (params) {
self.unselect(params.data);
var option = container.$element.find('option')[0];
var data = Utils.GetData(option, 'data');
self.unselect(data);
});
};

Expand Down
8 changes: 6 additions & 2 deletions src/js/select2/data/select.js
Expand Up @@ -110,11 +110,15 @@ define([
this.container = container;

container.on('select', function (params) {
self.select(params.data);
var option = container.$element.find('option')[0];
var data = Utils.GetData(option, 'data');
self.select(data);
});

container.on('unselect', function (params) {
self.unselect(params.data);
var option = container.$element.find('option')[0];
var data = Utils.GetData(option, 'data');
self.unselect(data);
});
};

Expand Down

0 comments on commit 8258567

Please sign in to comment.