Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd (meta) Key in Select 2 4.0 #3400

Closed
snichini opened this issue May 22, 2015 · 3 comments
Closed

Cmd (meta) Key in Select 2 4.0 #3400

snichini opened this issue May 22, 2015 · 3 comments

Comments

@snichini
Copy link

Hello,

I see that in the 4.0 you're able to maintain the ctrl key while selecting multiple values and the toggle menu stays opened.

In OSX if you click left + ctrl key holded, the right context menu appears.

If you add the metaKey event for the same behavior it would be great for OSX users.
While pressing the cmd key and left click it works.

I add this by replacing:

// Don't close if the control key is being held
                    if (originalEvent && originalEvent.ctrlKey) {
                        return;
                    }

BY

// Don't close if the control key is being held
                    if (originalEvent && (originalEvent.ctrlKey || originalEvent.metaKey)) {
                        return;
                    }

AND

else if ((key === KEYS.SPACE && evt.ctrlKey)) {

BY

else if ((key === KEYS.SPACE && (evt.ctrlKey || evt.metaKey))) {

hope this can be in the next version

@kevin-brown
Copy link
Member

Pull requests are always appreciated.

@snichini
Copy link
Author

@kevin-brown yes I know. I didn't have the time to do it.i'm in a rush right now

@stale
Copy link

stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants