Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input with items already selected reads blank when focused with NVDA #4418

Closed
10 of 16 tasks
stevenbriscoeca opened this issue Jun 13, 2016 · 23 comments · Fixed by #5842
Closed
10 of 16 tasks

Input with items already selected reads blank when focused with NVDA #4418

stevenbriscoeca opened this issue Jun 13, 2016 · 23 comments · Fixed by #5842

Comments

@stevenbriscoeca
Copy link

stevenbriscoeca commented Jun 13, 2016

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate
  • The issue still exists against the latest master branch of Select2
  • This is not a usage question (Those should be directed to the community)
  • I have attempted to find the simplest possible steos to reproduce the issue
  • I have included a failing test as a pull request (Optional)

Steps to reproduce the issue

  1. Go to this codepen : http://codepen.io/stephendesjardins/pen/jrWmgq
  2. NVDA with firefox
  3. Select a few options
  4. NVDA will not announce what options are already selected

Expected behavior and actual behavior

I was expecting that NVDA tell us what option are already selected

Environment

Browsers

  • Google Chrome
  • Mozilla Firefox
  • Internet Explorer

Operating System

  • Windows
  • Mac OS X
  • Linux
  • Mobile

Libraries

  • jQuery version: 2.2.4
  • Select2 version:4.0.3 and version that is on master

Isolating the problem

  • This bug happens on the examples page
  • The bug happens consistently across all tested browsers
  • This bug happens when using Select2 without other pluigns
  • I can reproduce this bug in a codepen

Here is what I mean, when it says "vide", it means "empty"
select2

@kevin-brown
Copy link
Member

This sounds like a duplicate of #3735.

@stevenbriscoeca
Copy link
Author

stevenbriscoeca commented Jun 13, 2016

That issue is about changing search result options in the select-container. I'm talking about when you already selected a few options and then you go back to that input, there is no way of knowing that they're already a few options selected in that input (see gif attached).

@ashokramadoss
Copy link

if any fix available fro JAWS16 and NVDA

@acconrad
Copy link

acconrad commented Dec 13, 2017

I opened this Codepen in Firefox and it looks like it's working. Can probably close this:

screen shot 2017-12-13 at 13 54 53

@alexweissman
Copy link
Contributor

@acconrad it appears that this issue is about the NV Access (NVDA) screen reader - are you using that?

@acconrad
Copy link

@alexweissman you're totally right, I read that wrong. Please ignore, sorry!

@alexweissman alexweissman changed the title Accessibility : reads blank when options are already selected NV Access reads blank when options are already selected Dec 14, 2017
@alexweissman
Copy link
Contributor

Actually, this is a duplicate of #3735, so we can close it after all!

@stevenbriscoeca
Copy link
Author

@alexweissman I already explained to @kevin-brown that this is another issue and he reopened it
please see : #4418 (comment)

Do not close this issue. It is not a duplicate
#4418 (comment)

@alexweissman
Copy link
Contributor

JAWS is silent when changing options, and NVDA reads "blank".

Isn't that the exact same issue you described?

NVDA will not announce what options are already selected

@stevenbriscoeca
Copy link
Author

@alexweissman

My issue is when you go back into an input with a few items selected, it reads the input as blank instead of that there is something already in the input. So when someone comes into the input with a few items and it reads blank, it gives the impression that there is nothing there. So the user with a disability will submit a form thinking he has only one item in the input when it has three.

The issue that you are referencing is trying to navigate in the options which read blank.

I would highly recommend you look at the gif I posted in this comment : #4418 (comment)

You will have a better idea of the difference.

Hopefully you will re-open this issue. If you need any clarification, please let me know.

@alexweissman
Copy link
Contributor

Ok, please edit the title of this issue to make the difference more clear, so it doesn't get closed again in the future.

@alexweissman alexweissman reopened this Dec 15, 2017
@stevenbriscoeca stevenbriscoeca changed the title NV Access reads blank when options are already selected Input with items already selected reads blank when focused with NVDA Dec 15, 2017
@stevenbriscoeca
Copy link
Author

Changed the title to reflect better the issue. Let me know what you think! thanks

@alexweissman
Copy link
Contributor

Thanks. It could still be the same root cause as #3735, but we'll leave it open until you have time to investigate the cause of these issues more 😄

@Amarjit
Copy link

Amarjit commented Feb 15, 2018

An interim fix would be to disable the auto-complete.

    $("#your_select_element").on('select2:open', function (e) {
        $('.select2-search input').prop('focus',false);
    });

@stale
Copy link

stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Mar 13, 2019
@stevenbriscoeca
Copy link
Author

please don't close this issue. It is very much still a problem

@stale stale bot removed the status: stale label Mar 13, 2019
@stale
Copy link

stale bot commented May 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label May 12, 2019
@kevin-brown
Copy link
Member

Reopening this since it's still not fixed and we still consider it to be an issue.

We welcome pull requests that fix this issue, by the way.

@stale stale bot removed the status: stale label May 15, 2019
@stale
Copy link

stale bot commented Jul 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Jul 14, 2019
@kevin-brown
Copy link
Member

Still welcoming pull requests, I'll gladly review them.

@stevenbriscoeca
Copy link
Author

Hi @kevin-brown ,

I made a PR that fixes this issue in firefox. Let me know if you have any feedback on it.

Let's get this done!

@kevin-brown kevin-brown added this to the 4.0.9 milestone Jul 20, 2019
@kevin-brown kevin-brown modified the milestones: 4.0.9, 4.0.10, 4.0.11 Aug 22, 2019
@kevin-brown kevin-brown modified the milestones: 4.0.11, 4.0.12 Oct 13, 2019
@kevin-brown kevin-brown modified the milestones: 4.0.12, 4.0.13 Nov 6, 2019
@stale
Copy link

stale bot commented Jan 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@kevin-brown
Copy link
Member

I have opened a pull request at #5842 which aims to redo the accessibility of the selection area with multiple and single selects to make them more accessible to screen readers. One of the main changes involves changing the selection to ensure the selected items are read out to the user when the search and other areas are focused.

While I understand that it has been a while, it would be greatly appreciated if anyone could help us test out these changes to ensure this ticket has been fixed. You can test these on your own by recompiling Select2 from the lastest develop branch, or you can wait for the next beta release (which should be out once that pull request is merged). Our goal is to significantly improve the accessibility in time for the upcoming 4.1.0 release of Select2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants