Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown position on AJAX searches #5253

Closed
mattalberon opened this issue Mar 16, 2018 · 4 comments · Fixed by #5592
Closed

Dropdown position on AJAX searches #5253

mattalberon opened this issue Mar 16, 2018 · 4 comments · Fixed by #5592
Labels
4.x confirmed bug

Comments

@mattalberon
Copy link

Version 4.0.5

Steps to reproduce the bug:

  1. Open https://select2.org/data-sources/ajax and resize your browser height such that the 'search for a repository' box appears at the bottom the viewport, forcing the dropdown to appear above
  2. Type a string e.g. 'matthew'
  3. Wait for the results to display
  4. Delete the string by selecting all, and pressing backspace
  5. You should the advisory text label hanging where the top of the results list used to be i.e. not flush with the top of the search box - see attached screenshot.

image
@AStoker
Copy link

AStoker commented Apr 2, 2018

Has already been reported here: #4614

@luesak
Copy link

luesak commented Feb 20, 2019

I got a video here: https://youtu.be/ykbAxAI6_k8

@stale
Copy link

stale bot commented Apr 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Apr 21, 2019
@stale stale bot removed the status: stale label Apr 28, 2019
@0lorak0
Copy link

0lorak0 commented May 15, 2019

Followed the trail from #4616 (Closed Issue) to #5196 (Open Pull Request)

@ivaynberg ivaynberg added the 4.x label Jun 27, 2019
kevin-brown pushed a commit that referenced this issue Jul 28, 2019
@AStoker @kevin-brown
Fix dropdown positioning when displayed above with messages
c33f8e0 
This fixes an issue which was usually observed when working with
AJAX results sets and having a message being displayed, usually the
minimum characters message or an error. The dropdown would display
up, like it was supposed to, but the message would appear to be
floating above the container and detached.

This was occuring because the dropdown position was not being
calculated whenever a message was displayed in the results, only
when the results were loaded or new results were appended to an existing
results set. There are plenty of situations where this could have
caused issues, but somehow most of the reports were around a very
specific situation with AJAX which could be reproduced on the
examples site.

Fixes #4614
Fixes #4616
Fixes #5253
Closes #5196
@kevin-brown kevin-brown mentioned this issue Jul 28, 2019
Merged
3 tasks
kevin-brown added a commit that referenced this issue Jul 28, 2019
@kevin-brown
Fix dropdown positioning when displayed above with messages (#5592)
472e5ad 
This fixes an issue which was usually observed when working with
AJAX results sets and having a message being displayed, usually the
minimum characters message or an error. The dropdown would display
up, like it was supposed to, but the message would appear to be
floating above the container and detached.

This was occuring because the dropdown position was not being
calculated whenever a message was displayed in the results, only
when the results were loaded or new results were appended to an existing
results set. There are plenty of situations where this could have
caused issues, but somehow most of the reports were around a very
specific situation with AJAX which could be reproduced on the
examples site.

Fixes #4614
Fixes #4616
Fixes #5253
Closes #5196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x confirmed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dropdown positioning when displayed above with messages select2/select2
6 participants
@ivaynberg @0lorak0 @kevin-brown @AStoker @luesak @mattalberon