Avoid error on empty search result in MultiSelect. Fixes #2942 #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added padding to ".select2-search" container instead of margin for ".select2-search input". This fixes bug of "#select2" movement when resizing page. Steps to reproduce the bug: - open select2 so it appears above the input - resize the window Actual results: - #select2-drop moves up by 4px Expected results: - #select2-drop stays in same place
Case: the dropdown should be shouwn above input. PositionDropdown function then operates by showing dropdown below (and ".select2-search input" has no margin, it gets the wrong dropdown size). Then in the same function calculates the top value, but doesnt take into account, that input will have the "margin-top: 4px". Thus dropdown is displayed 4px lower. Then the window resizes, the dropdown position is already correct, but then calculations (outerHeight()) get the height including the ".select2-search input" margin of 4px and thus moves the dropdown up.
Fix select2#2282. When a select box is empty (this appends in my case, I have a dynamic select box), the search box should not be shown.
Hide search box if select is empty
Spelling mistake for jsDelivr
Add padding to select2 container displayed above
…input don't display a hidden input on destroy
fix vietnamese grammar mistakes
Fix performance issue with setVal on MultiSelect
If you call element.attr ('style') with Zepto and
there is NO inline style, you get back the
CSS2Properties object. In jQuery you would get
nothing.
To avoid calling split in an object instead of a
string we should check if we really have a string.
Signed-off-by: Leo Unglaub <leo@leo-unglaub.net>
Update copyright year
Remove aria-activedescendant attribute after the dropdown is closed, to make sure the aria properties is vaild for aduit-tool [https://code.google.com/p/accessibility-developer-tools/wiki/AuditRules#AX_ARIA_04:_ARIA_state_and_property_values_must_be_valid]
Fix accessible aria activedescendant attribute
Little typo
Ember JS component link.
The documentation for the current version is still at http://select2.github.io/select2/. Once 4.0 moves on a little further, we will switch these links to https://select2.github.io/.
Update README.md
the dot, denoting a namespace and not an event name, was missing
Properly off() the events in the "select2" namespace
|
Now that 4.0.0 has been released, the branches have switched and this is pointing to the wrong one. If you are still interested in getting this merged, create a new pull request for the Until then, we have to close this off as it is not possible to merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.