Improve usability of select2 in node environment with browserify #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this PR be merged or has it already been dealt with in the main branch? |
|
This has not yet been merged as we still need to look into it. |
|
@kevin-brown - thanks for the prompt response! And @leftmostcat for the fork to potentially use in the meantime. |
|
any chance this gets merged? |
|
This should have been fixed by 8edf3c6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple issues that result from select2 being require()d in a node environment and then browserified for use client-side, as set out in #3282 and #3287. This PR solves both of these issues.