remove the href property from the select2-search-choice-close link #3754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Select2 no longer officially supports the 3.x version line, and will no longer be accepting pull requests to correct issues present in it. It is highly recommended to upgrade to the latest version of Select2 if you can, as that is the version which will continue to be supported in the future. If this issue is still present in the latest version of Select2, or the feature has not yet been added, we encourage you to submit a new pull request against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the URL is actually changing to '#' in the Ember.js framework version 1.13. Since this is unnecessary because the anchor tag is not actually being used as a link, perhaps it would be best to remove the href attribute altogether.