[Fix] attachBody - reposition dropdown on message display #5186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: select2#4614 Previous behavior: whenever a message is displayed, results are cleared out, but dropdown is not repositioned, resulting in a floating search box based off of last position. Fixed behavior: when a message is displayed, reposition the dropdown accordingly
|
@alexweissman, you mind giving this a review? |
|
Would it help if I make this PR to be merged into the Develop branch? |
1 task
|
Any word on this being merged into the main branch? |
|
Can't help the feeling that Select2 is dead/dying, unless a new maintainer steps up to merge PR's |
|
We have @AStoker's fix already in production and it's working nicely. Why the waiting? I also assume, that the maintainer have moved elsewhere and abandoned this repository. |
|
Continue discussion here -> #5196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4614
accordingly
This pull request includes a
The following changes were made
results:messageevent) we reposition/resize the dropdown (due to messages clearing out results, but not taking into account new dropdown height).