Passed dropdown parent shall be wrapped in $()

[mlt]

If passing a non-jQuery object (string), a .css call throws an exception $offsetParent.css is not a function in AttachBody.prototype._positionDropdown.

This pull request includes a

• Bug fix
• New feature
• Translation

The following changes were made

• Call $() on passed dropdownParent / data-dropdown-parent in AttachBody
• It seems generally safe to call $() on already a jQuery objects

If this is related to an existing ticket, include a link to it as well.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mlt]

ehm...is there anything holding this one that I shall fix? I kind of rely on it and it has a test.

[kevin-brown]

I know it's been a few months and we dropped the ball on this one, but this generally looks good and it's my goal to get it merged in.

But before we do that, is there any chance you can split your test changes out so we have two different tests? One for passing in a jQuery object and the other for passing in the selector.

[mlt]

I made a separate test case and rebased my branch.

[Peter-Potts]

Hi, thanks mlt for proposing this change.
I would also find it valuable - using the 'data-dropdown-parent' attribute (eg ="#myID') actually seems to fail otherwise.
Cheers

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.