Update highlightFirstItem to take tags in to consideration #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been thinking about this one for the last 9 days and I think the solution I'm aiming to go for is instead of modifying |
|
No problem, sounds like a neater way of doing it 👍 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Reopening as a reminder about the decorator plan since I don't see an attached ticket. |
…that option first
This switches the implementation to use a decorator which is only added when the `tags` option is set during initialization. Functionally it has no change on the effect but it allows for the logic to be more isolated. In the end it just keeps it more organized and works towards cutting back on what is included in the core results. This also changes the call for setting the `select2-data-tag` attribute to properly set the attribute as a string instead of relying on the boolean to string conversion.
kevin-brown
added
status: pending PR merge
and removed
status: needs additional work
status: pending PR merge
labels
anttikuuskoski
pushed a commit
to anttikuuskoski/select2
that referenced
this pull request
Mar 29, 2022
…t2#5812) * refactor: check for unselected options when using tags and highlight that option first * Switch to using a decorator for highlighting tags This switches the implementation to use a decorator which is only added when the `tags` option is set during initialization. Functionally it has no change on the effect but it allows for the logic to be more isolated. In the end it just keeps it more organized and works towards cutting back on what is included in the core results. This also changes the call for setting the `select2-data-tag` attribute to properly set the attribute as a string instead of relying on the boolean to string conversion. * Fix tabbing in newly added decorator * Add tests for tag focusing in results Co-authored-by: Kevin Brown <kevin@kevin-brown.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made:
Results.prototype.highlightFirstItemto check for unselected options and if thetagsoption is set. If so, highlight this first instead of a previously selected option.This works at the moment when no tags exist, but not when there are existing selected tags.
Fix
Current