New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aria-label 'Search' to search input when dropdown opens. #5824
Conversation
I'm going to evaluate the need for this soon as we are making some accessibility changes in the upcoming 4.1.0 release which would be a solid time for this pull request. Unfortunately it looks like this pull request includes changes to the |
Got it. Generally, other packages required the dist files to be included in the pull. |
1e67e9f
to
85b2884
Compare
Oh wait. This got closed somehow. I messed up my fork and did hard reset it to this branch. I've committed the changes. |
I'm pretty sure we need this for the dropdown search, and for consistency it probably makes sense to have it for the selection search as well (when the dropdown is open). The main changes that need to happen are:
|
Hey @kevin-brown, I've made the changes as mentioned. I've also added the test cases. |
…#5824) * Add aria-label 'Search' to search input when dropdown opens. * Fixex per review comments. Added test cases.
This pull request includes a
The following changes were made:
I've added an aria-label to the search box when dropdown opens. I've added a translation function for the label so that it can be set as per the language.