Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resell V2 - add cross-region subnets Get method #116

Merged

Conversation

kolsean
Copy link
Contributor

@kolsean kolsean commented Jan 5, 2019

  • Resell V2 - add cross-region subnets Get method

Add crossregionsubnets package with Get method and basic CrossRegionSubnet structure.
Provide tests and doc example.

  • Readme: add cross-region subnets link

Add link to the "crossregionsubnets" package documentation.

For #106

* Resell V2 - add cross-region subnets Get method

Add crossregionsubnets package with Get method and basic CrossRegionSubnet structure.
Provide tests and doc example.

* Readme: add cross-region subnets link

Add link to the "crossregionsubnets" package documentation.
Add spaces between // and comment messages.
Add VLANID and VTEPIPAddress fields to Subnet structure.
Fix Subnets field in CrossRegionSubnets structure.
Rename VlanID field to VLANID.
Fix test fixtures.
@kolsean
Copy link
Contributor Author

kolsean commented Jan 7, 2019

All fixes done.

Copy link
Contributor

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ozerovandrei ozerovandrei merged commit ee5acdd into selectel:master Jan 8, 2019
@kolsean kolsean deleted the resell-v2-crossregionsubnets-get branch January 8, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants