Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with response writing #121

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fix issue with response writing #121

merged 1 commit into from
Jan 30, 2019

Conversation

dstdfx
Copy link
Contributor

@dstdfx dstdfx commented Jan 29, 2019

  • Put response writing after reading request body
  • Add defered closing of the request body.

For #120

@dstdfx
Fix issue with response writing
36060a5 
* Put response writing after reading request body
* Add defered closing of the request body.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 192

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.326%
Totals Coverage Status
Change from base Build 189: 0.0%
Covered Lines: 979
Relevant Lines: 1027
💛 - Coveralls

ozerovandrei
ozerovandrei approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit 1a37ed6 into selectel:master Jan 30, 2019
@ozerovandrei ozerovandrei mentioned this pull request Jan 30, 2019
Closed
@dstdfx dstdfx deleted the fix/handler branch February 1, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstdfx @coveralls @ozerovandrei