Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and reconfigure golangci-lint #153

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Update and reconfigure golangci-lint #153

merged 1 commit into from
Aug 12, 2020

Conversation

ozerovandrei
Copy link
Contributor

@ozerovandrei ozerovandrei commented Aug 12, 2020 •
edited
Loading

Use Golangci-lint v1.30.0 in Travis CI.

Remove deprecated enable-all configuration from .golangci.yml.

Fix issues with gofumpt linter.

@coveralls
Copy link

coveralls commented Aug 12, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 312

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.714%
Totals Coverage Status
Change from base Build 311: 0.0%
Covered Lines: 938
Relevant Lines: 980
💛 - Coveralls

kolsean
kolsean approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozerovandrei
Update and reconfigure golangci-lint
4d089f6 
Use Golangci-lint v1.30.0 in Travis CI.

Remove deprecated enable-all configuration from .golangci.yml.

Fix issues with gofumpt linter.
@ozerovandrei ozerovandrei merged commit 2c2dd02 into selectel:master Aug 12, 2020
@ozerovandrei ozerovandrei deleted the new-golangci-lint branch August 12, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstdfx dstdfx dstdfx approved these changes

@kolsean kolsean kolsean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ozerovandrei @coveralls @dstdfx @kolsean