Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling with empty response body #7

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Fix error handling with empty response body #7

merged 1 commit into from
Feb 17, 2020

Conversation

kolsean
Copy link
Collaborator

@kolsean kolsean commented Feb 17, 2020

Update extractErr function in v1 package to handle errors with
empty response body properly. Provide test.

For #2

@kolsean
Fix error handling with empty response body
e0efb64 
Update extractErr function in v1 package to handle errors with
empty response body properly. Provide test.
ozerovandrei
ozerovandrei approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

dstdfx
dstdfx approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@dstdfx dstdfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kolsean kolsean merged commit d72f0a7 into selectel:master Feb 17, 2020
@kolsean kolsean deleted the fix/extract-err-with-empty-body branch February 17, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstdfx dstdfx dstdfx approved these changes

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kolsean @dstdfx @ozerovandrei