Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assertions for assertTrue and assertFalse #11

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

peter279k
Copy link
Member

Changed log

  • It seems that the test cases are all valid numbers and invalid numbers, and it can remove $expected variable.
    It can use assertFalse or assertTrue to assert the expected is false and true.

@odan odan merged commit 4258386 into selective-php:master Aug 12, 2020
@peter279k peter279k deleted the improve_assertions branch August 12, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants