Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch for #1141 #1169

Closed
wants to merge 1 commit into from
Closed

patch for #1141 #1169

wants to merge 1 commit into from

Conversation

ginlime
Copy link

@ginlime ginlime commented Oct 7, 2016

#1141 remove highlight always on refresh before highlighting matched terms inline

remove highlight always on refresh before highlighting matched terms inline
@Darep
Copy link

Darep commented Nov 8, 2016

I was experiencing the first character highlight bug (#1141) and can confirm this fixes it. Cheers! 🎉 👍

@joallard
Copy link
Member

joallard commented Dec 6, 2016

Sorry for not getting this, and thanks for the fix.

@joallard joallard closed this Dec 6, 2016
@Pictor13
Copy link
Contributor

@joallard What is the reason you did decide to not merge this patch?

I think people from #1141 could benefit from it.

@joallard
Copy link
Member

I have no idea.

@joallard joallard reopened this Nov 28, 2017
@mcavalletto
Copy link

It looks like this patch was applied in 8da5b51.

@joallard joallard closed this May 23, 2018
@ginlime
Copy link
Author

ginlime commented May 25, 2018

HAHAHA!
Exactly the same code by other person is merged!

I'm done.

@joallard
Copy link
Member

@ginlime Uh, hi?

I get that the other PR was made after yours, but let's keep in mind:

  1. The goal is to make this library as good as possible, which either PRs did; it's not about getting huge credit for a change of a few lines, and
  2. Managing and seeing clearly in a repo with 500 issues and 100+ PRs, with dozens piling up every week, and everyone wanting their pet issue fixed ASAP, is not exactly easy.

I'd suggest expressing your frustrations in a more constructive way next time. Thanks for stopping by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants