Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide autocomplete on Android #1176

Closed
wants to merge 2 commits into from
Closed

Hide autocomplete on Android #1176

wants to merge 2 commits into from

Conversation

ulriklystbaek
Copy link

Issue with browsers internal autocomplete gets shown in chrome on some Android devices. Seems to be that autocomplete is not respected when missing name. I have taken the attributes google uses on their input for google main page, and it seems to work.

Issue with browsers internal autocomplete gets shown in chrome on some Android devices. Seems to be that autocomplete is not respected when missing name. I have taken the attributes google uses on their input for google main page, and it seems to work.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6454fb4 on ulriklystbaek:patch-3 into * on selectize:master*.

@joallard
Copy link
Member

Okay for the attributes, not sure for the name, there could be collisions.

@ulriklystbaek
Copy link
Author

You are right, I went a bit fast. I have also gotten to know selectize alot better now, I will try to make a better solution later. But now I am finishing full Android support (backspace and keypress problems), and adding the ability to use other than 'text' also changing it after creation.

Updated to a more unique name. After testing the two attributes is not neccessary, only name is important.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bc70f04 on ulriklystbaek:patch-3 into * on selectize:master*.

@ulriklystbaek ulriklystbaek changed the title Update selectize.js Hide autocomplete on Android Oct 20, 2016
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2021

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants