Fix special char issue in firefox #1201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling bfe25a9 on topaxi:firefox-special-char-issue into * on selectize:master*. |
ThiefMaster
reviewed
Feb 20, 2017
src/utils.js
Outdated
| @@ -253,7 +253,7 @@ var measureString = function(str, $parent) { | |||
| ]); | |||
|
|
|||
| var width = $test.width(); | |||
| $test.remove(); | |||
| setTimeout(function() { $test.remove(); $test = null }, 0); | |||
There was a problem hiding this comment.
The $test = null doesn't seem to be very useful here
|
This issue seems to be caused by the It smells like a Firefox bug but this workaround would indeed help. Getting a bugfix release containing this fix would be very useful to our project since we have users complaining about this problem. |
topaxi
force-pushed
the
firefox-special-char-issue
branch
from
bfe25a9
to
dc82f00
Compare
|
Changes Unknown when pulling dc82f00 on topaxi:firefox-special-char-issue into ** on selectize:master**. |
|
Since Firefox has patched the issue on their side I'm going to close this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that in Firefox with newer versions of jQuery (version 2 or 3), that special characters like
@,-or even umlauts likeäwon't be inserted into the select box.I've tracked down the bug to the
measureStringfunction, I don't know what is really causing the bug, but if I remove the$testelement asynchronously, it seems to be working in Firefox again.Might be related to #809.