-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for returning promise like objects from load. #626
Conversation
If this feature is ever considered to be added to selectize, I will add tests and documentation for it, so this could be merged. Otherwise, feel free to close this PR. |
This is great! I also wish the render callbacks handled promises. |
Is this an api-breaking change? |
This shouldn't be breaking, as long as nobody is returning a promise from the load function and calling the done callback, which is very unlikely. |
I'm prepared to accept it. Can you add some test coverage? |
Rebased againts master and added some basic tests. |
Just going through a lot of my open PRs on Github. Anything left to do here from my side? Feel free to close this if you do not want to extend the selectize API with the proposed changes :) |
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
This PR allows the load setting to return promises instead of calling the provided callback.