Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for returning promise like objects from load. #626

Closed
wants to merge 3 commits into from

Conversation

topaxi
Copy link
Contributor

@topaxi topaxi commented Nov 20, 2014

This PR allows the load setting to return promises instead of calling the provided callback.

@topaxi
Copy link
Contributor Author

topaxi commented Nov 21, 2015

If this feature is ever considered to be added to selectize, I will add tests and documentation for it, so this could be merged. Otherwise, feel free to close this PR.

@Ramblurr
Copy link

This is great! I also wish the render callbacks handled promises.

@joallard
Copy link
Member

joallard commented Apr 1, 2016

Is this an api-breaking change?

@topaxi
Copy link
Contributor Author

topaxi commented Apr 2, 2016

This shouldn't be breaking, as long as nobody is returning a promise from the load function and calling the done callback, which is very unlikely.

@joallard
Copy link
Member

joallard commented Apr 2, 2016

I'm prepared to accept it. Can you add some test coverage?

@topaxi
Copy link
Contributor Author

topaxi commented Apr 4, 2016

Rebased againts master and added some basic tests.

@joallard joallard added this to the 0.13.0 milestone May 9, 2016
@topaxi
Copy link
Contributor Author

topaxi commented Aug 6, 2019

Just going through a lot of my open PRs on Github. Anything left to do here from my side? Feel free to close this if you do not want to extend the selectize API with the proposed changes :)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2021

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants