#2550 #2567 don't try to cast remote ChromeDriver

e.g. when Chrome is running in Selenoid
selenide · Feb 3, 2024 · 21bd9a8 · 21bd9a8
1 parent 49e19e0
commit 21bd9a8
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/main/java/com/codeborne/selenide/impl/DownloadFileToFolderCdp.java b/src/main/java/com/codeborne/selenide/impl/DownloadFileToFolderCdp.java
@@ -118,9 +118,8 @@ private File waitUntilDownloadsCompleted(Driver driver, FileFilter fileFilter,
   }
 
   private DevTools initDevTools(Driver driver) {
-    DevTools devTools;
-    if (driver.browser().isChromium()) {
-      devTools = ((HasDevTools) driver.getWebDriver()).getDevTools();
+    if (driver.browser().isChromium() && driver.getWebDriver() instanceof HasDevTools cdpBrowser) {
+      DevTools devTools = cdpBrowser.getDevTools();
       devTools.createSessionIfThereIsNotOne();
       devTools.send(Page.enable());
       return devTools;
@@ -231,8 +230,8 @@ public String toString() {
     }
   }
 
-  protected void failFastIfNoChanges(Driver driver, CdpDownloads downloads, FileFilter filter,
-                                     long downloadStartedAt, long timeout, long incrementTimeout) {
+  private void failFastIfNoChanges(Driver driver, CdpDownloads downloads, FileFilter filter,
+                                   long downloadStartedAt, long timeout, long incrementTimeout) {
     long now = currentTimeMillis();
     long lastModifiedAt = downloads.lastModificationTime().orElse(downloadStartedAt);
     long filesHasNotBeenUpdatedForMs = now - lastModifiedAt;