Skip to content

Commit

Permalink
#2550 #2567 properly unwrap webdriver (e.g. in case of remote webdriv…
Browse files Browse the repository at this point in the history
…er on Selenoid)
  • Loading branch information
asolntsev committed Feb 6, 2024
1 parent 72a8c38 commit e861333
Showing 1 changed file with 11 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.util.function.Consumer;

import static com.codeborne.selenide.impl.FileHelper.moveFile;
import static com.codeborne.selenide.impl.WebdriverUnwrapper.cast;
import static java.lang.System.currentTimeMillis;
import static java.util.Collections.emptyMap;
import static java.util.Objects.requireNonNull;
Expand Down Expand Up @@ -118,16 +119,17 @@ private File waitUntilDownloadsCompleted(Driver driver, FileFilter fileFilter,
}

private DevTools initDevTools(Driver driver) {
if (driver.browser().isChromium() && driver.getWebDriver() instanceof HasDevTools cdpBrowser) {
DevTools devTools = cdpBrowser.getDevTools();
devTools.createSessionIfThereIsNotOne();
devTools.send(Page.enable());
return devTools;
}
else {
throw new IllegalArgumentException("The browser you selected \"%s\" doesn't have Chrome Devtools protocol functionality."
.formatted(driver.browser().name));
if (driver.browser().isChromium()) {
Optional<HasDevTools> cdpBrowser = cast(driver.getWebDriver(), HasDevTools.class);
if (cdpBrowser.isPresent()) {
DevTools devTools = cdpBrowser.get().getDevTools();
devTools.createSessionIfThereIsNotOne();
devTools.send(Page.enable());
return devTools;
}
}
throw new IllegalArgumentException("The browser you selected \"%s\" doesn't have Chrome Devtools protocol functionality."
.formatted(driver.browser().name));
}

private void prepareDownloadWithCdp(Driver driver, DevTools devTools,
Expand Down

0 comments on commit e861333

Please sign in to comment.