Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenide could take a full-screen screenshot using CDP #1799

Closed
asolntsev opened this issue May 10, 2022 · 0 comments · Fixed by #1800 or #1858
Closed

Selenide could take a full-screen screenshot using CDP #1799

asolntsev opened this issue May 10, 2022 · 0 comments · Fixed by #1800 or #1858
Assignees
@rosolko
Labels
feature screenshots
Milestone
6.7.0

Comments

@asolntsev
Copy link
Member

see https://github.com/diemol/selenium-4-demo/blob/master/src/test/java/com/saucelabs/demo/BiDiTest.java#L107
@rosolko rosolko mentioned this issue May 10, 2022
Merged
3 tasks
@asolntsev asolntsev added this to the 6.6.0 milestone Jun 1, 2022
@asolntsev asolntsev mentioned this issue Jun 1, 2022
Closed
@asolntsev asolntsev linked a pull request Jun 1, 2022 that will close this issue
Feature/#1799 full screen screenshots #1831
Closed
asolntsev added a commit that referenced this issue Jun 1, 2022
@asolntsev
#1799 fix unit-tests
f3198a6
asolntsev added a commit that referenced this issue Jun 1, 2022
@asolntsev
#1799 read all browser parameters with a single JS call (to speed up …
01cfebc 
…the test)
asolntsev added a commit that referenced this issue Jun 1, 2022
@asolntsev
#1799 support all CDP browsers, not only Chrome and Edge
a5fa936 
there is more browsers supporting CDP: Chromium, Brave, Opera...
asolntsev added a commit that referenced this issue Jun 1, 2022
@asolntsev
#1799 fix test: we open browser of size 1200x960 in tests
2ada8da
asolntsev added a commit that referenced this issue Jun 1, 2022
@asolntsev
#1799 fix test: we open browser of size 1200x960 in tests
4920762
asolntsev added a commit that referenced this issue Jun 1, 2022
@asolntsev
#1799 fix test on Firefox on github actions
6b631ad
asolntsev added a commit that referenced this issue Jun 1, 2022
@asolntsev
Merge branch 'master' into feature/#1799-full-screen-screenshots
7577379
asolntsev added a commit that referenced this issue Jun 2, 2022
@asolntsev
Merge branch 'master' into feature/#1799-full-screen-screenshots
6b1f82c
asolntsev added a commit that referenced this issue Jun 2, 2022
@asolntsev
#1799 fix test on Firefox on github actions
e1640fa 
some day it was 1185
asolntsev added a commit that referenced this issue Jun 2, 2022
@asolntsev
#1799 fix test on Firefox on github actions
bbbd105 
some day it was 1185
asolntsev added a commit that referenced this issue Jun 2, 2022
@asolntsev
#1799 fix checkstyle issue in WebdriverPhotographer
548ec71
asolntsev added a commit that referenced this issue Jun 6, 2022
@asolntsev
Merge branch 'master' into feature/#1799-full-screen-screenshots
fe4e388
asolntsev added a commit that referenced this issue Jun 6, 2022
@asolntsev
#1799 fix test: I have no idea why the browser height was 1188 at tha…
5f8d983 
…t moment
asolntsev added a commit that referenced this issue Jun 7, 2022
@asolntsev
#1799 fix test: I have no idea why the browser width was 1206 at that…
98bf5b3 
… moment
asolntsev added a commit that referenced this issue Jun 7, 2022
@asolntsev
#1799 use Firefox built-in feature "getFullPageScreenshotAs"
46c8a07 
it's much faster than CDP, and doesn't generate tons of JS warnings.
asolntsev added a commit that referenced this issue Jun 8, 2022
@asolntsev
#1799 temporary run only screenshots-related tests
7ef07d9
asolntsev added a commit that referenced this issue Jun 8, 2022
@asolntsev
#1799 use a page of fixed size to verify the screenshot size
b749cf3
asolntsev added a commit that referenced this issue Jun 8, 2022
@asolntsev
#1799 cast to HasCdp instead of ChromiumDriver
3d4b32d 
* when user adds a listener to webdriver, it gets wrapped to a proxy object which is not instance of ChromiumDriver anymore
* but which still implemented HasCdp interface.
asolntsev added a commit that referenced this issue Jun 8, 2022
@asolntsev
#1799 support both Retina and other displays
eaf1311
@asolntsev asolntsev modified the milestones: 6.6.0, 6.7.0 Jun 8, 2022
asolntsev added a commit that referenced this issue Jun 16, 2022
@asolntsev
#1799 implement full-size screenshots as a separate Selenide plugin
d729624 
this is a re-worked PR #1800 and PR #1831
@asolntsev asolntsev linked a pull request Jun 16, 2022 that will close this issue
#1799 implement full-size screenshots as a separate Selenide plugin #1858
Merged
asolntsev added a commit that referenced this issue Jun 25, 2022
@asolntsev
#1799 implement full-size screenshots as a separate Selenide plugin
251349f 
this is a re-worked PR #1800 and PR #1831
asolntsev added a commit that referenced this issue Jun 25, 2022
@asolntsev
#1799 restore test case for full-size screenshots in Grid
9d72073 
taken from https://github.com/selenide/selenide/pull/1831/files#diff-e2def06948ba15e7c0f8b354d365a70938c34dbef7ecfb002fc27a537805d884
asolntsev added a commit that referenced this issue Jun 25, 2022
@asolntsev
#1799 make CDP screenshooting fail-safe
9413021 
take a "default" screenshot if CDP screenshot has failed.
asolntsev added a commit that referenced this issue Jun 25, 2022
@asolntsev
#1799 ignore the test on Edge
9fe3816
asolntsev added a commit that referenced this issue Jun 25, 2022
@asolntsev
#1799 restore test case for full-size screenshots in Grid
d7df8fa 
taken from https://github.com/selenide/selenide/pull/1831/files#diff-e2def06948ba15e7c0f8b354d365a70938c34dbef7ecfb002fc27a537805d884
asolntsev added a commit that referenced this issue Jun 25, 2022
@asolntsev
#1799 make CDP screenshooting fail-safe
92a3399 
take a "default" screenshot if CDP screenshot has failed.
asolntsev added a commit that referenced this issue Aug 3, 2022
@asolntsev
#1799 implement full-size screenshots as a separate Selenide plugin
e944839 
this is a re-worked PR #1800 and PR #1831
asolntsev added a commit that referenced this issue Aug 3, 2022
@asolntsev
#1799 restore test case for full-size screenshots in Grid
bc4029a 
taken from https://github.com/selenide/selenide/pull/1831/files#diff-e2def06948ba15e7c0f8b354d365a70938c34dbef7ecfb002fc27a537805d884
asolntsev added a commit that referenced this issue Aug 3, 2022
@asolntsev
#1799 make CDP screenshooting fail-safe
516fbc2 
take a "default" screenshot if CDP screenshot has failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosolko rosolko

Labels
feature screenshots
Projects
None yet
Milestone
6.7.0
2 participants
@asolntsev @rosolko