New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshot() of SelenideElement creates the file in "working dir" and without extension #290

Closed
vinogradoff opened this Issue Feb 12, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@vinogradoff
Member

vinogradoff commented Feb 12, 2016

should probably use .png and reportsDir instead...

@vinogradoff vinogradoff changed the title from screenshot() of Selenide element create the file in "working dir" and without extension to screenshot() of SelenideElement creates the file in "working dir" and without extension Feb 12, 2016

@pavelpp

This comment has been minimized.

Show comment
Hide comment
@pavelpp

pavelpp Apr 19, 2016

I can confirm that this is the case.

pavelpp commented Apr 19, 2016

I can confirm that this is the case.

@pavelpp

This comment has been minimized.

Show comment
Hide comment
@pavelpp

pavelpp Apr 19, 2016

It is using this method, which does not seem to be correct

protected String generateScreenshotFileName() {
    return currentContext + timestamp() + "." + screenshotCounter.getAndIncrement();
  }

It has dot in the wrong place and forgets to add "png". Moving file into a folder with corresponding test name would also make sense, I suppose.

pavelpp commented Apr 19, 2016

It is using this method, which does not seem to be correct

protected String generateScreenshotFileName() {
    return currentContext + timestamp() + "." + screenshotCounter.getAndIncrement();
  }

It has dot in the wrong place and forgets to add "png". Moving file into a folder with corresponding test name would also make sense, I suppose.

@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Apr 19, 2016

Contributor

Thank you for such a detailed description. It will help to fix the issue.

Contributor

asolntsev commented Apr 19, 2016

Thank you for such a detailed description. It will help to fix the issue.

@asolntsev asolntsev self-assigned this Aug 4, 2016

@asolntsev asolntsev added this to the 3.8 milestone Aug 4, 2016

@asolntsev asolntsev closed this in 331b15e Aug 4, 2016

asolntsev added a commit that referenced this issue Aug 4, 2016

@simple-elf

This comment has been minimized.

Show comment
Hide comment
@simple-elf

simple-elf Aug 5, 2016

Contributor

Thanks a lot. Faced same issue

Contributor

simple-elf commented Aug 5, 2016

Thanks a lot. Faced same issue

BorisOsipov added a commit to BorisOsipov/selenide that referenced this issue Nov 23, 2016

BorisOsipov added a commit to BorisOsipov/selenide that referenced this issue Nov 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment