Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshot() of SelenideElement creates the file in "working dir" and without extension #290

Closed
vinogradoff opened this issue Feb 12, 2016 · 4 comments
Assignees
Milestone

Comments

@vinogradoff
Copy link
Member

should probably use .png and reportsDir instead...

@vinogradoff vinogradoff changed the title screenshot() of Selenide element create the file in "working dir" and without extension screenshot() of SelenideElement creates the file in "working dir" and without extension Feb 12, 2016
@pavelpp
Copy link
Contributor

pavelpp commented Apr 19, 2016

I can confirm that this is the case.

@pavelpp
Copy link
Contributor

pavelpp commented Apr 19, 2016

It is using this method, which does not seem to be correct

protected String generateScreenshotFileName() {
    return currentContext + timestamp() + "." + screenshotCounter.getAndIncrement();
  }

It has dot in the wrong place and forgets to add "png". Moving file into a folder with corresponding test name would also make sense, I suppose.

@asolntsev
Copy link
Member

Thank you for such a detailed description. It will help to fix the issue.

@asolntsev asolntsev self-assigned this Aug 4, 2016
@asolntsev asolntsev added this to the 3.8 milestone Aug 4, 2016
asolntsev added a commit that referenced this issue Aug 4, 2016
@simple-elf
Copy link
Contributor

Thanks a lot. Faced same issue

BorisOsipov pushed a commit to BorisOsipov/selenide that referenced this issue Nov 23, 2016
BorisOsipov pushed a commit to BorisOsipov/selenide that referenced this issue Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants