Speedup tests: use short timeout by default #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
force-pushed
the
speedup-tests
branch
3 times, most recently
from
fa242f3
to
0625dfb
Compare
rosolko
reviewed
Apr 17, 2020
| @@ -26,7 +26,7 @@ void setUp() { | |||
| @Test | |||
| @Video | |||
| void userCanBrowseTabs_webdriver_api() { | |||
| openFile("page_with_tabs.html"); | |||
| setTimeout(1000); | |||
There was a problem hiding this comment.
Isn't openFile("page_with_tabs.html"); removed by mistake?
There was a problem hiding this comment.
No, the same line openFile("page_with_tabs.html"); is executed in setUp() method.
asolntsev
force-pushed
the
speedup-tests
branch
from
0625dfb
to
292ed15
Compare
.. and use bigger timeout explicitly only in tests that actually need it.
* "selenide.selectorMode" * "selenide.assertionMode"
asolntsev
force-pushed
the
speedup-tests
branch
from
292ed15
to
5c4e2cb
Compare
rosolko
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
gradlew check chrome_headless firefox_headlesscommand